Skip to content

[Test] Add focused hybrid MTP prefix-cache regressions - #53189

Merged
vllm-bot merged 1 commit into
vllm-project:mainfrom
mgoin:mgoin/hybrid-mtp-prefix-cache-tests
Aug 22, 2026
Merged

vllm-bot merged 1 commit into
vllm-project:mainfrom
mgoin:mgoin/hybrid-mtp-prefix-cache-tests

Conversation

@mgoin

@mgoin mgoin commented Aug 21, 2026

Copy link
Copy Markdown
Member

Summary

  • extend the existing hybrid chunked-prefill e2e suite with a direct regression for the hybrid Mamba prefix-hit bound under MTP
  • keep the existing mixed-batch short-prefill regression, add the Nemotron NVFP4 checkpoint, and run both models at TP=1
  • reduce the optional NVIDIA job from 4xH100 to 1xB200 and retain the AMD mirror at 1xMI300

Related to #43559.

Why this is not a duplicate

#48970 adds a separate, broadly calibrated correctness harness with model-specific control and liveness machinery. This patch is a compact alternative: it reuses test_hybrid_chunked_prefill.py, constructs the exact one-block versus two-block boundary, directly asserts the cached-token invariant, and checks warm and uncached output correctness.

The focused open-PR searches found #48970 but no other PR modifying this existing suite for the same cases.

Tests

CUDA_VISIBLE_DEVICES=6 .venv/bin/python -m pytest \
  tests/v1/e2e/test_hybrid_chunked_prefill.py -v -s -k qwen
# 3 passed, 2 deselected

.venv/bin/pre-commit run ruff-format --files \
  tests/v1/e2e/test_hybrid_chunked_prefill.py
.venv/bin/pre-commit run ruff-check --files \
  tests/v1/e2e/test_hybrid_chunked_prefill.py
# passed

git diff origin/main...HEAD --check
# passed

The YAML parsed successfully. The full Nemotron real-weight e2e was not run locally; exact-checkpoint TP=1 dummy initialization consumed 75.36 GiB and fit under a conservative B200 memory budget. The optional B200 job provides the real-weight run.

Model evaluation is not applicable because this changes only tests and CI configuration; it does not change model output or serving behavior.

AI assistance

AI assistance was used to develop and test this change. The human submitter reviewed every changed line, understands the implementation and validation, and is responsible for defending the change end to end.

@mergify mergify Bot added the ci/build label Aug 21, 2026
@mgoin
mgoin force-pushed the mgoin/hybrid-mtp-prefix-cache-tests branch from 681be24 to 0aaf018 Compare August 21, 2026 02:38
@mgoin

mgoin commented Aug 21, 2026

Copy link
Copy Markdown
Member Author

/ci run

@github-actions

Copy link
Copy Markdown

✅ Triggered Buildkite CI #84942 for commit 0aaf018c44fa.

Signed-off-by: mgoin <mgoin64@gmail.com>
@mgoin
mgoin force-pushed the mgoin/hybrid-mtp-prefix-cache-tests branch from 0aaf018 to 30d2072 Compare August 21, 2026 02:48
@mgoin
mgoin marked this pull request as ready for review August 21, 2026 14:17
@mgoin
mgoin requested review from Harry-Chen and khluu as code owners August 21, 2026 14:17

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 21, 2026
@mgoin

mgoin commented Aug 21, 2026

Copy link
Copy Markdown
Member Author

/ci run

@github-actions

Copy link
Copy Markdown

✅ Triggered Buildkite CI #85079 for commit 30d2072670ab.

@vllm-bot
vllm-bot merged commit a34f2ab into vllm-project:main Aug 22, 2026
31 checks passed
@mgoin
mgoin deleted the mgoin/hybrid-mtp-prefix-cache-tests branch August 22, 2026 00:05
am-cohere pushed a commit to am-cohere/vllm that referenced this pull request Sep 1, 2026
mikeshawcode pushed a commit to mikeshawcode/vllm that referenced this pull request Sep 1, 2026
…53189)

Signed-off-by: mgoin <mgoin64@gmail.com>
Signed-off-by: mikeshawcode <michaelwshaw2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants