[Bugfix][LoRA] Use an explicit capability flag for tower connector LoRA - #53092
Merged
jeejeelee merged 3 commits intoAug 21, 2026
Merged
Conversation
linitra24
requested review from
jeejeelee,
patrickvonplaten,
sighingnow and
vadiklyutiy
as code owners
August 20, 2026 10:15
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
linitra24
changed the title
This was referenced Aug 20, 2026
jeejeelee
approved these changes
Aug 21, 2026
Member
|
/ci run |
jeejeelee
enabled auto-merge (squash)
August 21, 2026 02:49
github-actions
Bot
added
the
ready
|
✅ Triggered Buildkite CI #84944 for commit |
Contributor
Author
|
/ci run |
|
✅ Triggered Buildkite CI #84957 for commit |
Contributor
Author
|
/ci run |
|
✅ Triggered Buildkite CI #84964 for commit |
JonSnow1807
added a commit
to JonSnow1807/vllm
that referenced
this pull request
Aug 22, 2026
Assisted-by: AI coding assistant Signed-off-by: JonSnow1807 <JonSnow1807@users.noreply.github.com>
4 tasks
am-cohere
pushed a commit
to am-cohere/vllm
that referenced
this pull request
Sep 1, 2026
…RA (vllm-project#53092) Signed-off-by: linitra24 <Joy25810@foxmail.com>
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_num_mm_encoder_tokensis defined onSupportsMultiModal, so every model that inherits this interface has the method even if it does not implement it. Therefore, the previoushasattrcheck always returnedTruefor multimodal models and could incorrectly enable tower connector LoRA.Replace the
hasattr(model, "get_num_mm_encoder_tokens")check with an explicitsupports_tower_connector_loracapability flag.Purpose
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.