[Model] Dynamic image size support for LLaVA-NeXT#5279
Closed
DarkLight1337 wants to merge 18 commits intovllm-project:mainfrom
DarkLight1337:mm-image-tokenizer-llava
Closed
[Model] Dynamic image size support for LLaVA-NeXT#5279DarkLight1337 wants to merge 18 commits intovllm-project:mainfrom DarkLight1337:mm-image-tokenizer-llava
DarkLight1337 wants to merge 18 commits intovllm-project:mainfrom
DarkLight1337:mm-image-tokenizer-llava
Conversation
This was referenced Jun 5, 2024
Member
Author
Member
Author
|
#5276 is in a pretty good spot now so I'll delete this branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A proof-of-concept showcasing the application of input processor for inserting a dynamic number of image tokens. This is required to fully take advantage of the multi-resolution feature in LLaVA-NeXT.
Related contributions
This PR is essentially #5276 applied on top of #4199. It will leave draft status when both dependences are merged.
Update: Since #4199 has been merged, #5276 now supersedes this PR.