Skip to content

[XPU] upgrade requirements/test/xpu.txt - #52672

Merged
jikunshang merged 3 commits into
vllm-project:mainfrom
mayuyuace:qiming/upgrade_pytest
Aug 19, 2026
Merged

jikunshang merged 3 commits into
vllm-project:mainfrom
mayuyuace:qiming/upgrade_pytest

Conversation

@mayuyuace

@mayuyuace mayuyuace commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

BUG:
https://buildkite.com/vllm/intel-ci/builds/9136/canvas?sid=01a01157-7bc4-4dd2-9cbd-d6f16677b983&tab=output
tests/engine/test_arg_utils.py::test_prefix_cache_retention_interval_from_deprecated_env FAILED on XPU CI, PASSED on CUDA CI.

Root cause:
The pytest version specified in requirements/test/xpu.txt for XPU is 9.0.2, whereas the version in requirements/test/cuda.txt for CUDA is 9.1.0.
The test uses the caplog fixture to capture vLLM's WARNING logs; however, the vLLM logger is configured with propagate=False (in vllm/logger.py:67), meaning logs do not propagate to the root logger. In pytest 9.0.2, caplog relies on propagation to the root logger, so it fails to capture the logs; consequently, caplog.text is empty, and the assertion fails. pytest 9.1.0 addresses this behavior, allowing it to directly capture logs from loggers where propagate=False.

Fix:
Re-compile requirements/test/xpu.txt to update all packages.

Signed-off-by: mayuyuace <qiming1.zhang@intel.com>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@mergify mergify Bot added ci/build intel-gpu Related to Intel GPU labels Aug 18, 2026
Signed-off-by: mayuyuace <qiming1.zhang@intel.com>
@mayuyuace mayuyuace changed the title [XPU] upgrade pytest [XPU] upgrade requirements/test/xpu.txt Aug 18, 2026
@jikunshang

Copy link
Copy Markdown
Member

/ci run

@github-actions

Copy link
Copy Markdown

✅ Triggered Buildkite CI #84331 for commit a983ddc872fb.

Signed-off-by: Qiming Zhang <qiming1.zhang@intel.com>
@mayuyuace

Copy link
Copy Markdown
Contributor Author

/ci run

@github-actions

Copy link
Copy Markdown

✅ Triggered Buildkite CI #84513 for commit 00d4c7d9fccd.

@jikunshang
jikunshang merged commit 03b87dc into vllm-project:main Aug 19, 2026
17 of 18 checks passed
@mayuyuace
mayuyuace deleted the qiming/upgrade_pytest branch August 19, 2026 03:32
wenhuach21 pushed a commit to wenhuach21/vllm that referenced this pull request Aug 19, 2026
Signed-off-by: mayuyuace <qiming1.zhang@intel.com>
Signed-off-by: Qiming Zhang <qiming1.zhang@intel.com>
Signed-off-by: Wenhua Cheng <wenhua.cheng@intel.com>
zufangzhu pushed a commit to zufangzhu/vllm that referenced this pull request Aug 24, 2026
Signed-off-by: mayuyuace <qiming1.zhang@intel.com>
Signed-off-by: Qiming Zhang <qiming1.zhang@intel.com>
Signed-off-by: Zhu, Zufang <zufang.zhu@intel.com>
am-cohere pushed a commit to am-cohere/vllm that referenced this pull request Sep 1, 2026
Signed-off-by: mayuyuace <qiming1.zhang@intel.com>
Signed-off-by: Qiming Zhang <qiming1.zhang@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build intel-gpu Related to Intel GPU

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants