[ROCm][CI] Avoid forcing FlashAttention in the ColPali pooling test - #52565
Merged
Merged
Conversation
Signed-off-by: Andreas Karatzas <Andreas.Karatzas@amd.com>
mergify
Bot
added
multi-modality
AndreasKaratzas
marked this pull request as ready for review
August 17, 2026 03:02
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Member
Author
|
/ci run |
|
✅ Triggered Buildkite CI #84143 for commit |
noooop
approved these changes
Aug 17, 2026
Member
Author
|
I forgot to unblock the test that I was targeting to fix: Test is passing :) |
4 tasks
zyp2014
pushed a commit
to zyp2014/vllm
that referenced
this pull request
Aug 21, 2026
…llm-project#52565) Signed-off-by: Andreas Karatzas <Andreas.Karatzas@amd.com>
wyettzeng
pushed a commit
to wyettzeng/vllm
that referenced
this pull request
Aug 21, 2026
…llm-project#52565) Signed-off-by: Andreas Karatzas <Andreas.Karatzas@amd.com> Signed-off-by: Wyett <wyettzeng@gmail.com>
zufangzhu
pushed a commit
to zufangzhu/vllm
that referenced
this pull request
Aug 24, 2026
…llm-project#52565) Signed-off-by: Andreas Karatzas <Andreas.Karatzas@amd.com> Signed-off-by: Zhu, Zufang <zufang.zhu@intel.com>
khushali9
pushed a commit
to khushali9/vllm
that referenced
this pull request
Aug 29, 2026
…llm-project#52565) Signed-off-by: Andreas Karatzas <Andreas.Karatzas@amd.com> Signed-off-by: khushali9 <khushali.desai9@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #52050 added a CUDA-specific forced
FLASH_ATTNconfiguration to a cross-platform ColPali test, which then failed on both MI300 and MI355 because ROCm intentionally does not report a FlashAttention version. This keeps the intended CUDA regression coverage while allowing ROCm to select its supported attention backend.