Skip to content

[Bugfix] Fix MultiprocessingGPUExecutor.check_health when world_size == 1 #5254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simon-mo merged 2 commits into from
Jun 11, 2024
Merged

[Bugfix] Fix MultiprocessingGPUExecutor.check_health when world_size == 1 #5254

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
920eba8
fix: check worker_monitor is defined
jsato8094 Jun 4, 2024
84a9178
refactor: set worker_monitor to None when world_size is 1
jsato8094 Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion vllm/executor/multiproc_gpu_executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ def _init_executor(self) -> None:

if world_size == 1:
self.workers = []
self.worker_monitor = None
else:
result_handler = ResultHandler()
self.workers = [
Expand Down Expand Up @@ -127,7 +128,8 @@ def _run_workers(

def check_health(self) -> None:
"""Raises an error if engine is unhealthy."""
if not self.worker_monitor.is_alive():
if self.worker_monitor is not None and not self.worker_monitor.is_alive(
):
raise RuntimeError("Worker processes are not running")

def _wait_for_tasks_completion(self, parallel_worker_tasks: Any) -> None:
Expand Down