[Bugfix] Fix a bug caused by pip install setuptools>=49.4.0 for CPU backend#5249
Merged
WoosukKwon merged 1 commit intovllm-project:mainfrom Jun 4, 2024
Merged
Conversation
mgoin
approved these changes
Jun 4, 2024
Member
mgoin
left a comment
mgoin
left a comment
There was a problem hiding this comment.
Nice catch and thank you for your contribution!
Contributor
Author
|
Thanks @mgoin for your review. There are 5 failing checks of the CI tests which seem to be unrelated to my change. Thanks. |
Collaborator
|
@DamonFool Just force-merged. Thanks for the PR! |
Contributor
Author
|
Thanks @WoosukKwon . |
chengzhi-lu
pushed a commit
to chengzhi-lu/vllm-infersche
that referenced
this pull request
Jun 6, 2024
robertgshaw2-redhat
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
Jun 11, 2024
joerunde
pushed a commit
to joerunde/vllm
that referenced
this pull request
Jun 17, 2024
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jun 27, 2024
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jul 8, 2024
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jul 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all,
When I use
docker build -f Dockerfile.cpu -t vllm-cpu-env --shm-size=4g .to build a cpu docker, I find a file named=49.4.0in the CPU docker instance. Please see the following picture for this bug.It is caused by
in the Dockerfile.cpu
Actually,
pip install setuptools>=49.4.0is incorrect to install the expected setuptools, which can be fixed byIt would be better to fix it.
Thanks.
Best regards,
Jie