Bugfix: fix broken of download models from modelscope#5233
Merged
WoosukKwon merged 4 commits intovllm-project:mainfrom Jun 6, 2024
Merged
Bugfix: fix broken of download models from modelscope#5233WoosukKwon merged 4 commits intovllm-project:mainfrom
WoosukKwon merged 4 commits intovllm-project:mainfrom
Conversation
liuyhwangyh
force-pushed
the
fix_download_from_modelscope
branch
from
7a02025 to
a3fa75d
Compare
liuyhwangyh
changed the title
simon-mo
reviewed
Jun 4, 2024
Collaborator
There was a problem hiding this comment.
This test isn't ran at the moment, and I would prefer this be put inside test_regression if possible
Contributor
Author
There was a problem hiding this comment.
Moved to test_regression.py
simon-mo
reviewed
Jun 4, 2024
| trust_remote_code=trust_remote_code, | ||
| revision=revision, | ||
| code_revision=code_revision) | ||
| if VLLM_USE_MODELSCOPE: |
Collaborator
There was a problem hiding this comment.
can you use the following pattern?
if VLLM_USE_MODELSCOPE:
from modelscope import AutoConfig
auto_cls = AutoConfig
else:
from transformers import AutoConfig
auto_cls = AutoConfig
config = AutoConfig...
simon-mo
approved these changes
Jun 6, 2024
Collaborator
Contributor
Author
robertgshaw2-redhat
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
Jun 11, 2024
Closed
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIX #4362