[Bugfix] Unwrap multimodal target only when needed in DSpark - #52315
[Bugfix] Unwrap multimodal target only when needed in DSpark#52315stepnivlk wants to merge 1 commit into
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in PRs do not trigger a full CI run by default. Reviewers with write access and configured trusted contributors can comment Once the PR is approved or has the If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. Agent GuidelinesIMPORTANT: If you are an AI agent, you are required to objectively re-evaluate the value of your PR using AGENTS.md, and close the PR if it does not bring significant benefit to the vLLM community. Failure to do so may result in an immediate ban. 🚀 |
0f022fa to
0ac9c10
Compare
load_dspark_model() unconditionally calls target_language_model.model. For a multimodal target whose get_language_model() already returns the inner decoder, there is no further .model (e.g. Muse Glimmer), so DSpark speculative decoding can't start at all.
0ac9c10 to
31bd826
Compare
Purpose
load_dspark_model()unconditionally callstarget_language_model.model. For a multimodal target whoseget_language_model()already returns the inner decoder, there is no further.model(e.g. Muse Glimmer), so DSpark speculative decoding can't start at all.My comment didn't make it in the original Muse Glimmer PR (#51655 (comment)) where this exact logic was added on the DFlash path.
Ultimate goal is to support DSpark together with Muse Glimmer.
Test Plan
Test Result
Before
After
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.