Repository navigation
[Observability] log sub process killing in process manager force kill - #52314
Merged
DarkLight1337 merged 6 commits intoSep 30, 2026
Merged
DarkLight1337 merged 6 commits into
DarkLight1337 merged 6 commits into
Conversation
Signed-off-by: Andy Xie <andy.xning@gmail.com>
andyxning
marked this pull request as ready for review
August 27, 2026 06:17
DarkLight1337
approved these changes
Sep 30, 2026
DarkLight1337
enabled auto-merge (squash)
September 30, 2026 04:27
Member
|
/ci run |
|
✅ Triggered Buildkite CI #92038 for commit |
This was referenced Oct 4, 2026
liulanze
added a commit
to liulanze/vllm
that referenced
this pull request
Oct 9, 2026
vllm-project#52314 started logging each child's name() before SIGKILLing it, inside suppress(ProcessLookupError). psutil raises NoSuchProcess, not ProcessLookupError, when the child was reaped after children() listed it. That race is likely on the force-kill path, where the target is still tearing down and reaping its own children. The exception escapes kill_process_tree, so the remaining children and the target itself are never killed, and callers such as shutdown() abort their loop over the remaining processes. Suppress NoSuchProcess as well: a child that is already gone needs no SIGKILL, and skipping it avoids signalling a recycled pid. Signed-off-by: Lanze Liu <lanzetech@gmail.com>
liulanze
added a commit
to liulanze/vllm
that referenced
this pull request
Oct 12, 2026
Per review, keep this PR to the vllm-project#52314 regression: move children() back out of the try and drop the target-exit test. In the remaining test, end the child that exits mid-walk with SIGTERM instead of SIGKILL and assert it, so it is clearly told apart from the processes that kill_process_tree SIGKILLs. Signed-off-by: Lanze Liu <lanzetech@gmail.com>
michael-gpu
pushed a commit
to practical-inference/vllm-ampere-extended
that referenced
this pull request
Oct 20, 2026
…vllm-project#52314) Signed-off-by: Andy Xie <andy.xning@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.
Purpose
This is a follow up of #52299.
Add sub process killing log in process manager force kill by
kill_process_tree. For now, the kill process tree logic is not logged.Test Plan
export VLLM_ENGINE_READY_TIMEOUT_S=120vllm serve Qwen/Qwen3.6-27B --max-num-seqs 512 --renderer-num-workers 1 --tensor-parallel-size 2 --pipeline_parallel_size 2 --data-parallel-size 1Test Result
a detailed log will be recorded about sub process force kill.
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.BEFORE SUBMITTING, PLEASE READ https://docs.vllm.ai/en/latest/contributing (anything written below this line will be removed by GitHub Actions)