Skip to content

Support DSpark configs with architectures=DSparkDraftModel + model_type=qwen3 - #52197

Merged
mgoin merged 1 commit into
vllm-project:mainfrom
neuralmagic:support-specforge-qwen-dspark
Aug 17, 2026
Merged

mgoin merged 1 commit into
vllm-project:mainfrom
neuralmagic:support-specforge-qwen-dspark

Conversation

@mgoin

@mgoin mgoin commented Aug 13, 2026

Copy link
Copy Markdown
Member

Purpose

Generic Qwen DSparkDraftModel is now normalized to Qwen3DSparkModel so models like https://huggingface.co/RadixArk/Qwen3.8-2.4T-A95B-DSpark can now run on vLLM

Test Plan

Test Result

Tested gsm8k with

vllm serve mgoin/Qwen3.8-2.4T-A95B-NVFP4-pruned75 -tp=4 --spec-model RadixArk/Qwen3.8-2.4T-A95B-DSpark --spec-method dspark --spec-tokens 7
...
(APIServer pid=2078258) INFO 08-13 17:48:18 [metrics.py:120] SpecDecoding metrics: Mean acceptance length: 4.90, Accepted throughput: 1537.03 tokens/s, Drafted throughput: 2757.00 tokens/s, Accepted: 15372 tokens, Drafted: 27573 tokens, Per-position acceptance rate: 0.901, 0.795, 0.667, 0.550, 0.436, 0.327, 0.225, Avg Draft acceptance rate: 55.8%

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

architectures=DSparkDraftModel+model_type=qwen3

Signed-off-by: mgoin <mgoin64@gmail.com>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@mergify mergify Bot added the qwen Related to Qwen models label Aug 13, 2026
@mgoin mgoin added speculative-decoding ready ONLY add when PR is ready to merge/full CI is needed labels Aug 13, 2026
@mgoin

mgoin commented Aug 13, 2026

Copy link
Copy Markdown
Member Author

/ci run

@github-actions

Copy link
Copy Markdown

✅ Triggered Buildkite CI #83770 for commit 549263154901.

@mgoin
mgoin merged commit 7075dda into vllm-project:main Aug 17, 2026
103 of 106 checks passed
zyp2014 pushed a commit to zyp2014/vllm that referenced this pull request Aug 21, 2026
…_type=qwen3` (vllm-project#52197)

Signed-off-by: mgoin <mgoin64@gmail.com>
wyettzeng pushed a commit to wyettzeng/vllm that referenced this pull request Aug 21, 2026
…_type=qwen3` (vllm-project#52197)

Signed-off-by: mgoin <mgoin64@gmail.com>
Signed-off-by: Wyett <wyettzeng@gmail.com>
zufangzhu pushed a commit to zufangzhu/vllm that referenced this pull request Aug 24, 2026
…_type=qwen3` (vllm-project#52197)

Signed-off-by: mgoin <mgoin64@gmail.com>
Signed-off-by: Zhu, Zufang <zufang.zhu@intel.com>
khushali9 pushed a commit to khushali9/vllm that referenced this pull request Aug 29, 2026
…_type=qwen3` (vllm-project#52197)

Signed-off-by: mgoin <mgoin64@gmail.com>
Signed-off-by: khushali9 <khushali.desai9@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

qwen Related to Qwen models ready ONLY add when PR is ready to merge/full CI is needed speculative-decoding

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants