Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Running the profile run with DBO effectively sets the max batch size to
max_num_tokens // 2. If vllm bails out of DBO for any reason, it can end up in a situation where it's running with a batch size that is larger thanmax_num_tokens // 2. Deep EP v2 crashes in this case because an internal buffer wasn't sized correctly, but it's plausible that there is other undesirable behavior in the system when we encounter this scenario.The fix is to run the profile run with DBO explicitly disabled.
Test Result
lm_eval result