[Misc] Add missing return type annotations in outputs.py - #52145
Merged
DarkLight1337 merged 2 commits intoAug 13, 2026
Merged
DarkLight1337 merged 2 commits into
DarkLight1337 merged 2 commits into
Conversation
Signed-off-by: Vineeta Tiwari <vineeta.tiwari2@ibm.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
DarkLight1337
added
the
verified
DarkLight1337
enabled auto-merge (squash)
August 13, 2026 10:25
github-actions
Bot
added
the
ready
Member
|
/ci run |
|
✅ Triggered Buildkite CI #83728 for commit |
zyp2014
pushed a commit
to zyp2014/vllm
that referenced
this pull request
Aug 21, 2026
…t#52145) Signed-off-by: Vineeta Tiwari <vineeta.tiwari2@ibm.com> Co-authored-by: Vineeta Tiwari <vineeta.tiwari2@ibm.com>
zufangzhu
pushed a commit
to zufangzhu/vllm
that referenced
this pull request
Aug 24, 2026
…t#52145) Signed-off-by: Vineeta Tiwari <vineeta.tiwari2@ibm.com> Co-authored-by: Vineeta Tiwari <vineeta.tiwari2@ibm.com> Signed-off-by: Zhu, Zufang <zufang.zhu@intel.com>
khushali9
pushed a commit
to khushali9/vllm
that referenced
this pull request
Aug 29, 2026
…t#52145) Signed-off-by: Vineeta Tiwari <vineeta.tiwari2@ibm.com> Co-authored-by: Vineeta Tiwari <vineeta.tiwari2@ibm.com> Signed-off-by: khushali9 <khushali.desai9@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Add missing return type annotations to from_base() static methods and PoolingRequestOutput.repr() in vllm/outputs.py.
All from_base() static methods on EmbeddingOutput, ClassificationOutput, ScoringOutput, EmbeddingRequestOutput, ClassificationRequestOutput, and ScoringRequestOutput lacked return type annotations.
PoolingRequestOutput.repr() was missing -> str, making it the only repr in the file without one — every other repr in the same file already has it.
No logic changes.
Test Plan
pre-commit run ruff-check --files vllm/outputs.py
pre-commit run mypy-3.10 --files vllm/outputs.py --hook-stage manual
Test Result
ruff check...........Passed
Run mypy for Python 3.10...........Passed