Revert "[Perf][ROCm] Dual-stream decode with hipgraphs" - #52024
Merged
AndreasKaratzas merged 3 commits intoAug 13, 2026
Merged
AndreasKaratzas merged 3 commits into
AndreasKaratzas merged 3 commits into
Conversation
simondanielsson
requested review from
mgoin,
pavanimajety and
zyongye
as code owners
August 12, 2026 17:05
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
Author
|
The PR previously broke CI for DP with hybrid models : https://buildkite.com/vllm/amd-ci/builds/11962/list?sid=019ff533-827d-49d0-804e-938ff4efe9d8&tab=output |
4 tasks
simondanielsson
force-pushed
the
revert-48223-feat/dual-stream-decode-rocm
branch
from
August 12, 2026 17:07
f2e6bd6 to
198d902
Compare
4 tasks
|
✅ @simondanielsson, CI is now available for this PR.
|
Collaborator
Member
|
/ci run |
|
✅ Triggered Buildkite CI #83611 for commit |
Member
|
/ci run |
|
✅ Triggered Buildkite CI #83622 for commit |
Member
|
/ci run |
|
✅ Triggered Buildkite CI #83641 for commit |
AndreasKaratzas
enabled auto-merge (squash)
August 13, 2026 01:42
Collaborator
|
/ci retry |
shen-shanshan
approved these changes
Aug 13, 2026
|
✅ Queued 1 failed job(s) for retry in Buildkite CI #83641. |
iboiko-habana
pushed a commit
to vllm-project/vllm-gaudi
that referenced
this pull request
Aug 13, 2026
…e SharedExperts stream-sync in dp1 MoE fast path (+1 more) (#1732) This PR consolidates 2 fixes against vllm@`1c3633acafd6bbde1f3636cee9799e3ab0879d13`. Both symptoms are the same ~10-line shared-experts fast-path block and are co-resolved by one commit (697d798). ## Bug 1: Restore SharedExperts stream-sync in dp1 MoE fast path - **State machine id**: moerunner_apply_quant_method_overlapping_kwarg - **Commit**: 697d798 ### Root cause Upstream vLLM PR #52024 reverted PR #51838, restoring the shared-experts stream-synchronization path in the dp1 MoE fast path. The plugin MoERunner override had adapted to the #51838 shape and forwarded a shared_experts_overlapping keyword into MoERunner._apply_quant_method(); after the revert that parameter no longer exists upstream, so every MoE job raised TypeError: _apply_quant_method() got an unexpected keyword argument 'shared_experts_overlapping'. ### Upstream PR vllm-project/vllm#52024 Revert of vllm#51838, restoring the shared-experts stream-sync fast path. ### Fix Restore the shared-experts stream-sync block in the dp1 MoE fast path so the override matches post-revert upstream and stops forwarding the removed shared_experts_overlapping kwarg into MoERunner._apply_quant_method(). Single ~10-line block; both symptoms are co-resolved by this one commit. ## Bug 2: Restore SharedExperts.maybe_forward_async in dp1 MoE fast path - **State machine id**: sharedexperts_missing_maybe_forward_async - **Commit**: 697d798 ### Root cause Same upstream revert (vLLM PR #52024 reverting #51838). Post-revert, the shared-experts fast path again dispatches through SharedExperts.maybe_forward_async, but the plugin override had dropped that call, so MLA/MoE jobs raised AttributeError: 'SharedExperts' object has no attribute 'maybe_forward_async'. ### Upstream PR vllm-project/vllm#52024 Revert of vllm#51838, restoring the shared-experts stream-sync fast path. ### Fix Same commit: the restored fast-path block calls SharedExperts.maybe_forward_async again, matching post-revert upstream and clearing the AttributeError across MLA/MoE/PD jobs. Signed-off-by: Paweł Olejniczak <pawelx.olejniczak@intel.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #48223