Skip to content

[Bugfix][ROCm] Stop running shared experts on the aux stream #52010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stefankoncarevic wants to merge 2 commits into from
Closed

[Bugfix][ROCm] Stop running shared experts on the aux stream #52010

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bc776a
[Bugfix][ROCm] Stop running shared experts on the aux stream
stefankoncarevic Aug 12, 2026
27560cb
Merge branch 'main' into rocm-disable-shared-experts-overlap
stefankoncarevic Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions vllm/model_executor/layers/fused_moe/runner/shared_experts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,11 +103,10 @@ def _disable_shared_experts_overlap(self) -> bool:

@property
def _should_enable_stream_overlap_heuristic(self) -> bool:
# On ROCm, empirically it's shown that only DPA deployments benefit from
# multi-stream shared experts
if not current_platform.is_rocm():
return True
return self._moe_config.moe_parallel_config.dp_size > 1
# Workaround: the aux stream corrupts MoE output on ROCm, where this
# path first ran with #48223 -- Qwen3.5-35B-A3B at DP2 + EP on gfx950
# scores 0.00 on GSM8K. Keep it off until the cause is found.
return not current_platform.is_rocm()

def _determine_shared_experts_order(
self,
Expand Down
Loading