Skip to content

[Mypy Fix] Mypy fix for "vllm/model_executor/models/[cC][dD]" - #52003

Merged
DarkLight1337 merged 1 commit into
mainfrom
wentao-fix-mypy-models-cd
Aug 13, 2026
Merged

DarkLight1337 merged 1 commit into
mainfrom
wentao-fix-mypy-models-cd

Conversation

@yewentao256

Copy link
Copy Markdown
Member

Purpose

Mypy fix for "vllm/model_executor/models/[cC][dD]"

Test

pre-commit run --hook-stage manual mypy-3.13 -a
Run mypy for Python 3.13.................................................Passed

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@yewentao256 yewentao256 added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 12, 2026
@yewentao256

Copy link
Copy Markdown
Member Author

/ci run

@mergify mergify Bot added deepseek Related to DeepSeek models multi-modality Related to multi-modality (#4194) labels Aug 12, 2026
@github-actions

Copy link
Copy Markdown

✅ Triggered Buildkite CI #83567 for commit 06d10841fdf1.

@DarkLight1337

Copy link
Copy Markdown
Member

Tbh I don't see much value on getting mypy to pass on modeling files. Many model vendors don't care about type safety in their model implementations, enforcing this would just create more friction when they try to upstream their work.

@yewentao256 yewentao256 left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DarkLight1337 Thanks for taking a look, this is a longtime work, making higher code quality for the repo and avoid some potential bugs. I don't think taking care of this would add friction a lot as this is quite simple with AI now.

@DarkLight1337 DarkLight1337 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've made a point with AI being available to help with these issues. Let's see how it goes then

@DarkLight1337
DarkLight1337 merged commit 9a276d6 into main Aug 13, 2026
112 of 114 checks passed
@DarkLight1337
DarkLight1337 deleted the wentao-fix-mypy-models-cd branch August 13, 2026 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deepseek Related to DeepSeek models multi-modality Related to multi-modality (#4194) ready ONLY add when PR is ready to merge/full CI is needed speculative-decoding

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants