[Mypy Fix] Mypy fix for "vllm/model_executor/models/[cC][dD]" - #52003
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
|
/ci run |
|
✅ Triggered Buildkite CI #83567 for commit |
|
Tbh I don't see much value on getting mypy to pass on modeling files. Many model vendors don't care about type safety in their model implementations, enforcing this would just create more friction when they try to upstream their work. |
yewentao256
left a comment
There was a problem hiding this comment.
@DarkLight1337 Thanks for taking a look, this is a longtime work, making higher code quality for the repo and avoid some potential bugs. I don't think taking care of this would add friction a lot as this is quite simple with AI now.
DarkLight1337
left a comment
There was a problem hiding this comment.
You've made a point with AI being available to help with these issues. Let's see how it goes then
Purpose
Mypy fix for "vllm/model_executor/models/[cC][dD]"
Test
pre-commit run --hook-stage manual mypy-3.13 -a Run mypy for Python 3.13.................................................Passed