[Quant][MTP] Reuse packed FP8 logits inputs - #51947
Draft
WoosukKwon wants to merge 1 commit into
Draft
WoosukKwon wants to merge 1 commit into
WoosukKwon wants to merge 1 commit into
Conversation
Fuse the final draft all-reduce/RMSNorm with LM-head quantization while preserving BF16 feedback hidden states across MTP positions. Co-authored-by: OpenAI Codex <noreply@openai.com> Signed-off-by: Woosuk Kwon <woosuk@inferact.ai>
Contributor
|
This pull request has merge conflicts that must be resolved before it can be |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fuse the sparse DeepSeek V3.2 / GLM-5.2 MTP layer's final all-reduce and RMSNorm
with packed FP8 quantization for its shared LM head.
The draft layer returns two deliberately different values:
QuantizedActivationfor logits projection; andThe logits processor and both autoregressive speculators preserve and index this
contract without unpacking and requantizing it.
Dependencies
The branch contains only the seven-file MTP integration diff against
main.Until #51942 lands, isolated mypy reports the expected missing collective helper.
Duplicate-work check
No issue number was provided. I searched open PRs for
DeepSeek V3.2 fused norm quant MTP. The only exact prior implementation was the superseded draft#51936.
Tests
The portions independent of the missing prerequisite symbol pass directly:
.venv/bin/python -m pytest \ tests/fusion/test_quant_activation_contract.py \ tests/v1/worker/test_gpu_autoregressive_speculator.py -q # 23 passedOn the integrated branch:
.venv/bin/python -m pytest tests/models/deepseek_v32/test_sequence_parallel.py -q # 5 passedAll hooks other than the expected prerequisite-related mypy error pass.
Model evaluation
Two-node GB200, TP=8, C1, random 8K input / 1K output, MTP=3, ten measured
prompts, temperature 0:
Both runs completed all ten prompts without failures.
AI assistance disclosure
This change was developed with OpenAI Codex assistance. This is a blocked draft
PR; the human submitter must review every changed line and confirm they
understand and can defend the change before marking it ready.