Skip to content

[CI] Support partial torch requirement contexts - #51832

Merged
yewentao256 merged 4 commits into
vllm-project:mainfrom
taneem-ibrahim:fix-partial-torch-requirements-context
Aug 11, 2026
Merged

yewentao256 merged 4 commits into
vllm-project:mainfrom
taneem-ibrahim:fix-partial-torch-requirements-context

Conversation

@taneem-ibrahim

@taneem-ibrahim taneem-ibrahim commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Purpose

A clean CUDA CI image build runs use_existing_torch.py from a partial test-deps context without pyproject.toml, causing dependency setup to fail before tests. Treating that file as optional preserves the dependency cache while supporting partial contexts.

Reproducer

Run python use_existing_torch.py --prefix with requirements/ present and no pyproject.toml.

Output on main / on branch

Main: FileNotFoundError: [Errno 2] No such file or directory: 'pyproject.toml'

Branch: 8 passed, 14 warnings in 1.40s

Test Plan

.venv/bin/python -m pytest tests/tools/test_docker_build_metadata_args.py -q

AI assistance disclosure

OpenAI Codex (GPT-5) drafted the code and PR text. All changed lines were human-reviewed and tests human-run.

Signed-off-by: Taneem Ibrahim <taneem.ibrahim@gmail.com>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@taneem-ibrahim taneem-ibrahim changed the title [Docker][CI] Support partial torch requirement contexts [CI] Support partial torch requirement contexts Aug 11, 2026

@yewentao256 yewentao256 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks foe the work!

Comment thread tests/tools/test_docker_build_metadata_args.py Outdated
Co-authored-by: Wentao Ye <44945378+yewentao256@users.noreply.github.com>
Signed-off-by: Taneem Ibrahim <taneem.ibrahim@gmail.com>

@yewentao256 yewentao256 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the work!

Comment on lines +7 to +12
import sys
from pathlib import Path

REPO_ROOT = Path(__file__).resolve().parents[2]
HELPER = REPO_ROOT / ".buildkite" / "scripts" / "docker-build-metadata-args.sh"
USE_EXISTING_TORCH = REPO_ROOT / "use_existing_torch.py"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import sys
from pathlib import Path
REPO_ROOT = Path(__file__).resolve().parents[2]
HELPER = REPO_ROOT / ".buildkite" / "scripts" / "docker-build-metadata-args.sh"
USE_EXISTING_TORCH = REPO_ROOT / "use_existing_torch.py"
from pathlib import Path
REPO_ROOT = Path(__file__).resolve().parents[2]
HELPER = REPO_ROOT / ".buildkite" / "scripts" / "docker-build-metadata-args.sh"

Now becomes unused import

@yewentao256 yewentao256 added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 11, 2026
@github-actions

Copy link
Copy Markdown

@taneem-ibrahim, CI is now available for this PR.

  • /ci run starts a CI build.
  • /ci retry retries failed jobs in the CI build for the current PR head. If the current head has no CI build, it starts a new CI build for the current head containing only jobs that failed in the latest earlier CI build for this PR.
  • /ci cancel cancels scheduled or running CI builds for this PR branch.

@mergify

mergify Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Hi @taneem-ibrahim, the pre-commit checks have failed. Please run:

uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

@taneem-ibrahim

Copy link
Copy Markdown
Contributor Author

/ci run

@github-actions

Copy link
Copy Markdown

✅ Triggered Buildkite CI #83374 for commit 55420eb25027.

@taneem-ibrahim

Copy link
Copy Markdown
Contributor Author

/ci run

@github-actions

Copy link
Copy Markdown

✅ Triggered Buildkite CI #83381 for commit ff3a08a0ab5f.

@yewentao256
yewentao256 merged commit ca9c8cb into vllm-project:main Aug 11, 2026
17 checks passed
@taneem-ibrahim
taneem-ibrahim deleted the fix-partial-torch-requirements-context branch August 11, 2026 16:35
zyp2014 pushed a commit to zyp2014/vllm that referenced this pull request Aug 21, 2026
Signed-off-by: Taneem Ibrahim <taneem.ibrahim@gmail.com>
Co-authored-by: Wentao Ye <44945378+yewentao256@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants