[CI] Support partial torch requirement contexts - #51832
Merged
yewentao256 merged 4 commits intoAug 11, 2026
Merged
yewentao256 merged 4 commits into
yewentao256 merged 4 commits into
Conversation
Signed-off-by: Taneem Ibrahim <taneem.ibrahim@gmail.com>
yewentao256
reviewed
Aug 11, 2026
Co-authored-by: Wentao Ye <44945378+yewentao256@users.noreply.github.com> Signed-off-by: Taneem Ibrahim <taneem.ibrahim@gmail.com>
yewentao256
approved these changes
Aug 11, 2026
yewentao256
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks for the work!
Comment on lines
+7
to
+12
| import sys | ||
| from pathlib import Path | ||
|
|
||
| REPO_ROOT = Path(__file__).resolve().parents[2] | ||
| HELPER = REPO_ROOT / ".buildkite" / "scripts" / "docker-build-metadata-args.sh" | ||
| USE_EXISTING_TORCH = REPO_ROOT / "use_existing_torch.py" |
Member
There was a problem hiding this comment.
Suggested change
| import sys | |
| from pathlib import Path | |
| REPO_ROOT = Path(__file__).resolve().parents[2] | |
| HELPER = REPO_ROOT / ".buildkite" / "scripts" / "docker-build-metadata-args.sh" | |
| USE_EXISTING_TORCH = REPO_ROOT / "use_existing_torch.py" | |
| from pathlib import Path | |
| REPO_ROOT = Path(__file__).resolve().parents[2] | |
| HELPER = REPO_ROOT / ".buildkite" / "scripts" / "docker-build-metadata-args.sh" |
Now becomes unused import
|
✅ @taneem-ibrahim, CI is now available for this PR.
|
Contributor
|
Hi @taneem-ibrahim, the pre-commit checks have failed. Please run: uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, |
Contributor
Author
|
/ci run |
|
✅ Triggered Buildkite CI #83374 for commit |
Signed-off-by: Taneem Ibrahim <taneem.ibrahim@gmail.com>
Contributor
Author
|
/ci run |
|
✅ Triggered Buildkite CI #83381 for commit |
zyp2014
pushed a commit
to zyp2014/vllm
that referenced
this pull request
Aug 21, 2026
Signed-off-by: Taneem Ibrahim <taneem.ibrahim@gmail.com> Co-authored-by: Wentao Ye <44945378+yewentao256@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
A clean CUDA CI image build runs
use_existing_torch.pyfrom a partialtest-depscontext withoutpyproject.toml, causing dependency setup to fail before tests. Treating that file as optional preserves the dependency cache while supporting partial contexts.Reproducer
Run
python use_existing_torch.py --prefixwithrequirements/present and nopyproject.toml.Output on main / on branch
Main:
FileNotFoundError: [Errno 2] No such file or directory: 'pyproject.toml'Branch:
8 passed, 14 warnings in 1.40sTest Plan
.venv/bin/python -m pytest tests/tools/test_docker_build_metadata_args.py -qAI assistance disclosure
OpenAI Codex (GPT-5) drafted the code and PR text. All changed lines were human-reviewed and tests human-run.