Skip to content

fix and test EPLB balancedness calculation - #51813

Merged
vllm-bot merged 1 commit into
vllm-project:mainfrom
jdebache:eplb_balancedness_calculation_fix
Aug 13, 2026
Merged

vllm-bot merged 1 commit into
vllm-project:mainfrom
jdebache:eplb_balancedness_calculation_fix

Conversation

@jdebache

@jdebache jdebache commented Aug 11, 2026 •

Copy link
Copy Markdown
Contributor

Purpose

Fix EPLB balancedness logging to aggregate rank load within each MoE layer. The
current reduction uses the layer axis, so it can report perfect balance when one
EP rank receives all tokens in every layer.

Test Plan

pytest -q tests/distributed/test_eplb_algo.py

Test Result

The new regression case has equal token totals per layer with all tokens routed
to one rank. Before the fix, it produced avg_tokens=100 and max_tokens=100;
after the fix, it produces the expected avg_tokens=50 and max_tokens=200.

15 passed, 1 skipped

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • Documentation updates are not required for this metrics-only fix.

Signed-off-by: jdebache <jdebache@nvidia.com>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@ilmarkov ilmarkov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Basically revival of #39178 without additional changes

@tlrmchlsmth

Copy link
Copy Markdown
Member

/ci run

@github-actions

Copy link
Copy Markdown

✅ Triggered Buildkite CI #83351 for commit 43d62a1d20d5.

@jdebache jdebache changed the title fix and test EPBL balancedness calculation fix and test EPLB balancedness calculation Aug 11, 2026
@jdebache

Copy link
Copy Markdown
Contributor Author

It is unclear to me how the failure in CI is related to my changes. It looks infra related, and this step seems to be intermittently failing according to the CI dashboard.
@tlrmchlsmth: if you agree, would it be okay for you to merge it?

@vllm-bot
vllm-bot merged commit 6e502b6 into vllm-project:main Aug 13, 2026
74 of 76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants