Revert "[Perf] Narrow DeepSeek V4 eager CUDA graph region" (#51430) - #51750
Closed
vllm-agent wants to merge 1 commit into
Closed
vllm-agent wants to merge 1 commit into
vllm-agent wants to merge 1 commit into
Conversation
Collaborator
|
On it. |
2 tasks
Collaborator
|
I reproduced the regression as specific to the legacy V1 model runner's breakable PIECEWISE CUDA-graph path: the exact post-#51430 commit reached only 0.0311 GSM8K and 3–5% MTP draft acceptance under MRV1, while the unchanged code reached 0.9570 and 80.7–81.4% under MRV2. I revised #51768 into a narrower alternative to this revert: it leaves attention unchanged, defaults |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #51430 — "[Perf] Narrow DeepSeek V4 eager CUDA graph region" (merge commit
79c865b).Why
Nightly CI build #83211 (commit
635dd6a) failedMoE Refactor Integration Test (B200 - TEMPORARY):fac808b3, before #51430)635dd6aa, after)The other 18 configurations in the same job (Llama-4-Scout, Qwen3-30B-A3B, Mixtral-8x7B, Nemotron-Nano-30B) match between the two builds within normal noise. Only the DeepSeek-V4-Flash arm collapsed, and the collapse affects both the target model and the MTP drafter, which points at the model forward pass rather than the eval harness or the sampler.
Suspected mechanism
#51430 moved the
@eager_break_during_captureboundary fromattention_implto the new_sparse_indexer_and_attn. As a result the Q up-projection and_fused_qnorm_rope_kv_insert(q, kv, positions, attn_metadata)— which is metadata dependent — now run inside the captured CUDA graph rather than in the eager break, withattn_metadatabound at capture time. Replaying that graph reuses the captured slot mapping, so KV entries are written to stale locations and attention reads garbage.Attribution
#51430 is the only change to
vllm/models/deepseek_v4/attention.pyin the rangefac808b3..635dd6aa. Other DeepSeek-V4-adjacent commits in the range were ruled out: #50693 only relaxes a warmup assert inflashmla.py, #51296 touches the reasoning parser only (which cannot affect MTP acceptance), and #51602 touches parallel-drafting init for DSpark.The revert applied cleanly with no conflicts and the resulting diff is an exact inverse of #51430.
This is a performance optimization, so reverting restores correctness at the cost of the TTFT improvement. Happy to close this in favor of a fix-forward that keeps the KV insert in the eager region.
Auto-generated by CI failure analyzer.