[Testing] Fix test_sharded_state_loader - #51736
Merged
Merged
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
BoyuanFeng
approved these changes
Aug 10, 2026
zou3519
enabled auto-merge (squash)
August 10, 2026 22:32
Collaborator
Author
|
/ci run |
|
✅ Triggered Buildkite CI #83236 for commit |
This test compares the following: 1. load checkpoint -> generate outputs from prompts 2. load checkpoint -> reshard checkpoint -> reload checkpoint -> generate output from prompts Generating the output from prompts assumes batch invariance; if the vLLM scheduler schedules a different amount of batches across 1 and 2 then we can get different results. This PR forces the generation to do one sequence at a time to fix the batch size. This is what the rocm path did as well. Signed-off-by: Richard Zou <zou3519@gmail.com>
Collaborator
Author
|
/ci run |
|
✅ Triggered Buildkite CI #83409 for commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This test compares the following:
Generating the output from prompts assumes batch invariance; if the vLLM scheduler schedules a different amount of batches across 1 and 2 then we can get different results.
This PR forces the generation to do one sequence at a time to fix the batch size. This is what the rocm path did as well.
Test Plan
Run test with PyTorch 2.14, where the divergence showed up
Test Result
Test passed