[Kernel] Add GPU architecture guards to the CUTLASS w8a8 kernels to reduce binary size#5157
Merged
simon-mo merged 8 commits intovllm-project:mainfrom Jun 5, 2024
Merged
Conversation
Member
|
This seems reasonable to me (as in not too bad of a way to achieve this), is this in a land-able state given the passing checks? |
Member
Author
It's in a landable state. I want to measure the final size reduction for the wheel file when compiling for all CUDA ARCHS before marking it ready for review. I started to do this Friday but ran into some very long compile times edit: was in a landable state -- there will likely be merge conflicts now that #5144 has landed |
Member
Author
comaniac
approved these changes
Jun 4, 2024
Co-authored-by: Cody Yu <hao.yu.cody@gmail.com>
pcmoritz
approved these changes
Jun 4, 2024
chengzhi-lu
pushed a commit
to chengzhi-lu/vllm-infersche
that referenced
this pull request
Jun 6, 2024
…educe binary size (vllm-project#5157) Co-authored-by: Cody Yu <hao.yu.cody@gmail.com>
robertgshaw2-redhat
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
Jun 11, 2024
…educe binary size (vllm-project#5157) Co-authored-by: Cody Yu <hao.yu.cody@gmail.com>
joerunde
pushed a commit
to joerunde/vllm
that referenced
this pull request
Jun 17, 2024
…educe binary size (vllm-project#5157) Co-authored-by: Cody Yu <hao.yu.cody@gmail.com>
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jun 27, 2024
…educe binary size (vllm-project#5157) Co-authored-by: Cody Yu <hao.yu.cody@gmail.com>
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jul 8, 2024
…educe binary size (vllm-project#5157) Co-authored-by: Cody Yu <hao.yu.cody@gmail.com>
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jul 24, 2024
…educe binary size (vllm-project#5157) Co-authored-by: Cody Yu <hao.yu.cody@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR wraps the CUTLASS kernel definitions in order to guard against compilation on architectures that will never use a particular kernel. The purpose of this is to reduce the size of the compiled binary. Each CUTLASS kernel is defined and optimized for specific GPU architectures, but each kernel is compiled for every arch defined in
CUDA_SUPPORTED_ARCHS.The normal way to deal with this is to look at the macro
__CUDA_ARCH__. This macro is defined in the device-specific code but not on the host. All of our code runs on the host, so this PR uses these wrappers to "reach into" the device code to conditionally define the code.Results:
If I build
and then run the following (the strip is because I forgot to build in release mode):
main
this PR:
PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]for bug fixes.[CI/Build]for build or continuous integration improvements.[Doc]for documentation fixes and improvements.[Model]for adding a new model or improving an existing model. Model name should appear in the title.[Frontend]For changes on the vLLM frontend (e.g., OpenAI API server,LLMclass, etc.)[Kernel]for changes affecting CUDA kernels or other compute kernels.[Core]for changes in the core vLLM logic (e.g.,LLMEngine,AsyncLLMEngine,Scheduler, etc.)[Hardware][Vendor]for hardware-specific changes. Vendor name should appear in the prefix (e.g.,[Hardware][AMD]).[Misc]for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
format.shto format your code.docs/source/if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with
rfc-requiredand might not go through the PR.What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:
action-requiredlabel on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.Thank You
Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!