Skip to content

[K3] Allow tpu to import kimi_k3.common - #51529

Merged
ZJY0516 merged 1 commit into
vllm-project:mainfrom
majunze2001:jm-k3-tpu-common
Aug 9, 2026
Merged

ZJY0516 merged 1 commit into
vllm-project:mainfrom
majunze2001:jm-k3-tpu-common

Conversation

@majunze2001

Copy link
Copy Markdown
Contributor

Purpose

TPU platform plugins reuse Kimi K3's shared multimodal preprocessing while
registering their own model implementations. Avoid eagerly importing a GPU
implementation when the active platform's device type is TPU.

CUDA and ROCm model selection remains unchanged.

Not a duplicate

PR #51196 disables dynamic torch.compile for the Kimi vision encoder on TPU;
it does not address eager GPU model imports from the Kimi K3 package. Searches
for open PRs covering Kimi K3 TPU package imports found no duplicate.

Testing

uvx --from 'pre-commit>=4.5.1' pre-commit run --files vllm/models/kimi_k3/__init__.py
All applicable hooks passed.

git diff --check
Passed.

A TPU import smoke test confirmed that shared Kimi K3 preprocessing can be
imported without loading the NVIDIA or AMD model packages.

AI assistance

AI assistance was used to review the change and prepare this description. I
reviewed every changed line and can explain and defend the change end-to-end.

Signed-off-by: Jeff Ma <jeffjma@umich.edu>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@ZJY0516 ZJY0516 added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 9, 2026
@ZJY0516

ZJY0516 commented Aug 9, 2026

Copy link
Copy Markdown
Member

/ci run

@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown

✅ Triggered Buildkite CI #83045 for commit 00cb767457b7.

@ZJY0516
ZJY0516 merged commit 04d13b5 into vllm-project:main Aug 9, 2026
70 checks passed
khluu pushed a commit that referenced this pull request Aug 9, 2026
Signed-off-by: Jeff Ma <jeffjma@umich.edu>
(cherry picked from commit 04d13b5)
@majunze2001
majunze2001 deleted the jm-k3-tpu-common branch August 9, 2026 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

k3 kimi ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants