-
-
Notifications
You must be signed in to change notification settings - Fork 20.2k
[Kernel] Update Cutlass fp8 configs #5144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 7 commits
77cadb7
288c0f6
0657779
2a3913f
4a8e136
ce1c897
7038d3c
317cb72
5548622
707c3f3
6ac1961
221f31e
e11ac84
d0dd5be
316b7eb
f1b35eb
6319848
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,337 @@ | ||
| import argparse | ||
| import torch | ||
| import torch.utils.benchmark as TBenchmark | ||
| from torch.utils.benchmark import Measurement as TMeasurement | ||
| import time | ||
| import pickle as pkl | ||
|
|
||
| from weight_shapes import WEIGHT_SHAPES | ||
| from vllm import _custom_ops as ops | ||
| from typing import Tuple, Callable, Iterable | ||
|
|
||
| DEFAULT_MODELS = list(WEIGHT_SHAPES.keys())[1:] | ||
| DEFAULT_BATCH_SIZES = [1, 16, 32, 64, 128, 256, 512] | ||
|
|
||
| # helpers | ||
|
|
||
|
|
||
| def to_fp8(tensor: torch.tensor) -> torch.tensor: | ||
| finfo = torch.finfo(torch.float8_e4m3fn) | ||
| return torch.round(tensor.clamp( | ||
| min=finfo.min, max=finfo.max)).to(dtype=torch.float8_e4m3fn) | ||
|
|
||
|
|
||
| def to_int8(tensor: torch.tensor) -> torch.tensor: | ||
| return torch.round(tensor.clamp(min=-128, max=127)).to(dtype=torch.int8) | ||
|
|
||
|
|
||
| def make_rand_tensors(dtype: torch.dtype, m: int, n: int, | ||
| k: int) -> Tuple[torch.tensor, torch.tensor]: | ||
|
|
||
| a = torch.randn((m, k), device='cuda') * 5 | ||
| b = torch.randn((n, k), device='cuda').t() * 5 | ||
|
|
||
| if dtype == torch.int8: | ||
| return to_int8(a), to_int8(b) | ||
| if dtype == torch.float8_e4m3fn: | ||
| return to_fp8(a), to_fp8(b) | ||
|
|
||
| raise ValueError("unsupported dtype") | ||
|
|
||
|
|
||
| # impl | ||
|
|
||
|
|
||
| def pytorch_i8_impl(a: torch.tensor, b: torch.tensor, scale_a: torch.tensor, | ||
| scale_b: torch.tensor, | ||
| out_dtype: torch.dtype) -> torch.tensor: | ||
| return torch.mm(a, b) | ||
|
|
||
|
|
||
| def pytorch_fp8_impl(a: torch.tensor, b: torch.tensor, scale_a: torch.tensor, | ||
| scale_b: torch.tensor, | ||
| out_dtype: torch.dtype) -> torch.tensor: | ||
| return torch._scaled_mm(a, | ||
| b, | ||
| scale_a=scale_a, | ||
| scale_b=scale_b, | ||
| out_dtype=out_dtype) | ||
|
|
||
|
|
||
| def pytorch_fp8_impl_fast_accum(a: torch.tensor, b: torch.tensor, | ||
| scale_a: torch.tensor, scale_b: torch.tensor, | ||
| out_dtype: torch.dtype) -> torch.tensor: | ||
| return torch._scaled_mm(a, | ||
| b, | ||
| scale_a=scale_a, | ||
| scale_b=scale_b, | ||
| out_dtype=out_dtype, | ||
| use_fast_accum=True) | ||
|
|
||
|
|
||
| def cutlass_impl(a: torch.tensor, b: torch.tensor, scale_a: torch.tensor, | ||
| scale_b: torch.tensor, | ||
| out_dtype: torch.dtype) -> torch.tensor: | ||
| return ops.cutlass_scaled_mm_dq(a, | ||
| b, | ||
| scale_a, | ||
| scale_b, | ||
| out_dtype=out_dtype) | ||
|
|
||
|
|
||
| # bench | ||
| def bench_fn(a: torch.tensor, b: torch.tensor, scale_a: torch.tensor, | ||
| scale_b: torch.tensor, out_dtype: torch.dtype, label: str, | ||
| sub_label: str, fn: Callable, description: str) -> TMeasurement: | ||
|
|
||
| min_run_time = 1 | ||
|
|
||
| globals = { | ||
| "a": a, | ||
| "b": b, | ||
| "scale_a": scale_a, | ||
| "scale_b": scale_b, | ||
| "out_dtype": out_dtype, | ||
| "fn": fn, | ||
| } | ||
| return TBenchmark.Timer( | ||
| stmt="fn(a, b, scale_a, scale_b, out_dtype)", | ||
| globals=globals, | ||
| label=label, | ||
| sub_label=sub_label, | ||
| description=description, | ||
| ).blocked_autorange(min_run_time=min_run_time) | ||
|
|
||
|
|
||
| def bench_int8(dtype: torch.dtype, m: int, k: int, n: int, label: str, | ||
| sub_label: str) -> Iterable[TMeasurement]: | ||
| assert dtype == torch.int8 | ||
| a, b = make_rand_tensors(torch.int8, m, n, k) | ||
| scale_a = torch.tensor(1.0, device="cuda", dtype=torch.float32) | ||
| scale_b = torch.tensor(1.0, device="cuda", dtype=torch.float32) | ||
|
|
||
| timers = [] | ||
| # pytorch impl | ||
| timers.append( | ||
| bench_fn(a.to(dtype=torch.bfloat16, device="cuda"), | ||
| b.to(dtype=torch.bfloat16, device="cuda"), scale_a, scale_b, | ||
| torch.bfloat16, label, sub_label, pytorch_i8_impl, | ||
| "pytorch_bf16_bf16_bf16_matmul-no-scales")) | ||
|
mgoin marked this conversation as resolved.
|
||
|
|
||
| # cutlass impl | ||
| timers.append( | ||
| bench_fn(a, b, scale_a.to(device="cpu"), scale_b.to(device="cpu"), | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is it intentional to put the scales on the cpu?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. At the moment - yes. the scales are singleton tensors and the cutlass kernel interface will trigger a GPU-to-CPU copy if they aren't already on the CPU. We put the scales on the CPU so we don't time the copy. |
||
| torch.bfloat16, label, sub_label, cutlass_impl, | ||
| "cutlass_i8_i8_bf16_scaled_mm")) | ||
|
|
||
| return timers | ||
|
|
||
|
|
||
| def bench_fp8(dtype: torch.dtype, m: int, k: int, n: int, label: str, | ||
| sub_label: str) -> Iterable[TMeasurement]: | ||
| assert dtype == torch.float8_e4m3fn | ||
| a, b = make_rand_tensors(torch.float8_e4m3fn, m, n, k) | ||
| scale_a = torch.tensor(1.0, device="cuda", dtype=torch.float32) | ||
| scale_b = torch.tensor(1.0, device="cuda", dtype=torch.float32) | ||
|
|
||
| timers = [] | ||
|
|
||
| # pytorch impl: bf16 output, without fp8 fast accum | ||
| timers.append( | ||
| bench_fn(a, b, scale_a, scale_b, torch.bfloat16, label, sub_label, | ||
| pytorch_fp8_impl, "pytorch_fp8_fp8_bf16_scaled_mm")) | ||
|
|
||
| # pytorch impl: bf16 output, with fp8 fast accum | ||
| timers.append( | ||
| bench_fn(a, b, scale_a, scale_b, torch.bfloat16, label, sub_label, | ||
| pytorch_fp8_impl_fast_accum, | ||
| "pytorch_fp8_fp8_bf16_scaled_mm_fast_accum")) | ||
|
|
||
| # pytorch impl: fp16 output, without fp8 fast accum | ||
| timers.append( | ||
| bench_fn(a, b, scale_a, scale_b, torch.float16, label, sub_label, | ||
| pytorch_fp8_impl, "pytorch_fp8_fp8_fp16_scaled_mm")) | ||
|
|
||
| # pytorch impl: fp16 output, with fp8 fast accum | ||
| timers.append( | ||
| bench_fn(a, b, scale_a, scale_b, torch.float16, label, sub_label, | ||
| pytorch_fp8_impl_fast_accum, | ||
| "pytorch_fp8_fp8_fp16_scaled_mm_fast_accum")) | ||
|
|
||
| # cutlass impl: bf16 output | ||
| timers.append( | ||
| bench_fn(a, b, scale_a.to(device="cpu"), scale_b.to(device="cpu"), | ||
| torch.bfloat16, label, sub_label, cutlass_impl, | ||
| "cutlass_fp8_fp8_bf16_scaled_mm")) | ||
| # cutlass impl: fp16 output | ||
| timers.append( | ||
| bench_fn(a, b, scale_a.to(device="cpu"), scale_b.to(device="cpu"), | ||
| torch.float16, label, sub_label, cutlass_impl, | ||
| "cutlass_fp8_fp8_fp16_scaled_mm")) | ||
| return timers | ||
|
|
||
|
|
||
| def bench(dtype: torch.dtype, m: int, k: int, n: int, label: str, | ||
| sub_label: str) -> Iterable[TMeasurement]: | ||
| if dtype == torch.int8: | ||
| return bench_int8(dtype, m, k, n, label, sub_label) | ||
| if dtype == torch.float8_e4m3fn: | ||
| return bench_fp8(dtype, m, k, n, label, sub_label) | ||
| raise ValueError("unsupported type") | ||
|
|
||
|
|
||
| # runner | ||
| def print_timers(timers: Iterable[TMeasurement]): | ||
| compare = TBenchmark.Compare(timers) | ||
| compare.print() | ||
|
|
||
|
|
||
| def run(dtype: torch.dtype, | ||
| MKNs: Iterable[Tuple[int, int, int]]) -> Iterable[TMeasurement]: | ||
|
|
||
| results = [] | ||
| for m, k, n in MKNs: | ||
| timers = bench(dtype, m, k, n, f"scaled-{dtype}-gemm", | ||
| f"MKN=({m}x{k}x{n})") | ||
| print_timers(timers) | ||
| results.extend(timers) | ||
|
|
||
| return results | ||
|
|
||
|
|
||
| # output makers | ||
| def make_output(data: Iterable[TMeasurement], | ||
| MKNs: Iterable[Tuple[int, int, int]], | ||
| base_description: str, | ||
| timestamp=None): | ||
|
|
||
| print(f"== All Results {base_description} ====") | ||
| print_timers(data) | ||
|
|
||
| # pickle all the results | ||
| timestamp = int(time.time()) if timestamp is None else timestamp | ||
| with open(f"{base_description}-{timestamp}.pkl", "wb") as f: | ||
| pkl.dump(data, f) | ||
|
|
||
|
|
||
| # argparse runners | ||
|
|
||
|
|
||
| def run_square_bench(args): | ||
| dim_sizes = list( | ||
| range(args.dim_start, args.dim_end + 1, args.dim_increment)) | ||
| MKNs = list(zip(dim_sizes, dim_sizes, dim_sizes)) | ||
| data = run(args.dtype, MKNs) | ||
|
|
||
| make_output(data, MKNs, f"square_bench-{args.dtype}") | ||
|
|
||
|
|
||
| def run_range_bench(args): | ||
| dim_sizes = list(range(args.dim_start, args.dim_end, args.dim_increment)) | ||
| n = len(dim_sizes) | ||
| Ms = [args.m_constant] * n if args.m_constant is not None else dim_sizes | ||
| Ks = [args.k_constant] * n if args.k_constant is not None else dim_sizes | ||
| Ns = [args.n_constant] * n if args.n_constant is not None else dim_sizes | ||
| MKNs = list(zip(Ms, Ks, Ns)) | ||
| data = run(args.dtype, MKNs) | ||
|
|
||
| make_output(data, MKNs, f"range_bench-{args.dtype}") | ||
|
|
||
|
|
||
| def run_model_bench(args): | ||
|
|
||
| print("Benchmarking models:") | ||
| for i, model in enumerate(args.models): | ||
| print(f"[{i}] {model}") | ||
|
|
||
| model_bench_data = [] | ||
| models = args.models | ||
| for model in models: | ||
| Ms = args.batch_sizes | ||
| KNs = [] | ||
| for layer in WEIGHT_SHAPES[model]: | ||
| KNs.append((layer[0], layer[1])) | ||
|
|
||
| MKNs = [] | ||
| for m in Ms: | ||
| for k, n in KNs: | ||
| MKNs.append((m, k, n)) | ||
|
|
||
| data = run(args.dtype, MKNs) | ||
| model_bench_data.append(data) | ||
|
|
||
| # Print all results | ||
| for data, model in zip(model_bench_data, models): | ||
| print(f"== Results {args.dtype} {model} ====") | ||
| print_timers(data) | ||
|
|
||
| timestamp = int(time.time()) | ||
|
|
||
| all_data = [] | ||
| for d in model_bench_data: | ||
| all_data.extend(d) | ||
| # pickle all data | ||
| with open(f"model_bench-{args.dtype}-{timestamp}.pkl", "wb") as f: | ||
| pkl.dump(all_data, f) | ||
|
|
||
|
|
||
| if __name__ == '__main__': | ||
|
|
||
| def to_torch_dtype(dt): | ||
| if dt == "int8": | ||
| return torch.int8 | ||
| if dt == "fp8": | ||
| return torch.float8_e4m3fn | ||
| raise ValueError("unsupported dtype") | ||
|
|
||
| parser = argparse.ArgumentParser( | ||
| description=""" | ||
| Benchmark Cutlass GEMM. | ||
|
|
||
| To run square matrices gemm: | ||
| python3 ./benchmarks/cutlass_benchmarks.py --dtype fp8 square_bench --dim-start 128 --dim-end 512 --dim-increment 64 # noqa: E501 | ||
| To run constant N and K and sweep M: | ||
| python3 ./benchmarks/cutlass_benchmarks.py --dtype fp8 range_bench --dim-start 128 --dim-end 512 --dim-increment 64 --n-constant 16384 --k-constant 16384 # noqa: E501 | ||
| To run a model dimensions: | ||
| python3 ./benchmarks/cutlass_benchmarks.py --dtype fp8 model_bench --models meta-llama/Llama-2-7b-hf/TP1 --batch-sizes 16 # noqa: E501 | ||
|
|
||
| Output: | ||
| - a .pkl file, that is a list of raw torch.benchmark.utils.Measurements for the pytorch and cutlass implementations for the various gemms.# noqa: E501 | ||
| """, | ||
| formatter_class=argparse.RawTextHelpFormatter) | ||
|
|
||
| parser.add_argument("--dtype", | ||
| type=to_torch_dtype, | ||
| required=True, | ||
| help="Available options are ['int8', 'fp8']") | ||
|
mgoin marked this conversation as resolved.
|
||
| subparsers = parser.add_subparsers(dest="cmd") | ||
|
|
||
| square_parser = subparsers.add_parser("square_bench") | ||
| square_parser.add_argument("--dim-start", type=int, required=True) | ||
| square_parser.add_argument("--dim-end", type=int, required=True) | ||
| square_parser.add_argument("--dim-increment", type=int, required=True) | ||
| square_parser.set_defaults(func=run_square_bench) | ||
|
|
||
| range_parser = subparsers.add_parser("range_bench") | ||
| range_parser.add_argument("--dim-start", type=int, required=True) | ||
| range_parser.add_argument("--dim-end", type=int, required=True) | ||
| range_parser.add_argument("--dim-increment", type=int, required=True) | ||
| range_parser.add_argument("--m-constant", type=int, default=None) | ||
| range_parser.add_argument("--n-constant", type=int, default=None) | ||
| range_parser.add_argument("--k-constant", type=int, default=None) | ||
| range_parser.set_defaults(func=run_range_bench) | ||
|
|
||
| model_parser = subparsers.add_parser("model_bench") | ||
| model_parser.add_argument("--models", | ||
| nargs="+", | ||
| type=str, | ||
| default=DEFAULT_MODELS, | ||
| choices=WEIGHT_SHAPES.keys()) | ||
| model_parser.add_argument("--batch-sizes", | ||
| nargs="+", | ||
| type=int, | ||
| default=DEFAULT_BATCH_SIZES) | ||
| model_parser.set_defaults(func=run_model_bench) | ||
|
|
||
| args = parser.parse_args() | ||
| args.func(args) | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: renaming this to be more specific rather than the same name as the directory would be nice, such as
w8a8_benchmarks.pyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed 👍