[1/N] Harden Transformers modelling backend multi-modal path - #51408
Merged
Conversation
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
hmellor
requested review from
AndreasKaratzas,
DarkLight1337 and
ywang96
as code owners
August 7, 2026 15:20
DarkLight1337
approved these changes
Aug 7, 2026
DarkLight1337
left a comment
Member
There was a problem hiding this comment.
Let's get this fix in first, though I have a comment
Member
|
/ci run |
|
✅ Triggered Buildkite CI #82867 for commit |
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
hmellor
enabled auto-merge (squash)
August 7, 2026 16:05
Isotr0py
approved these changes
Aug 7, 2026
This was referenced Aug 10, 2026
xwu-intel
pushed a commit
to xwu-intel/vllm
that referenced
this pull request
Aug 13, 2026
…oject#51408) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Wu, Xiaochang <xiaochang.wu@intel.com>
skavulya
pushed a commit
to skavulya/vllm
that referenced
this pull request
Aug 15, 2026
…oject#51408) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
KeyError: "Modality 'image' not found".apply()ran_apply_visionwhenever the model supported images, not when items were present; themm_token_type_ids is Noneguard never fires because HF returns an all-zero tensor. Repro:BAAI/Emu3-Chat-hf+ a plain text prompt[2]became[2, 2], so ID and text prompts disagreedget_dummy_textemittedaudio_token * nwith no separator, so the run-length scan merged them. Verified: 3 items produced 1 placeholder, now 3_get_mm_fields_configmapped every key inhf_inputs, so whichever ran last took ownership. Keys are now attributed to the modality that produced them, derived from each sub-processor'smodel_input_namesTrueis_embedmask allocated per audio placeholderChanged
text_replacement_offsetswill fix it properlyTests
test_processing_correctness_transformers. The backend was excluded from_test_processing_correctness, so it had no cached-vs-uncached coverage at all. This caught the first two bugs