Repository navigation
[Bugfix] Skip fetching revision for model when model and weights_model are different - #51260
Merged
Merged
Conversation
…ferent Signed-off-by: Dino Music <Dino.Music@amd.com>
music-dino
requested review from
ProExpertProg,
WoosukKwon,
houseroad,
mgoin,
robertgshaw2-redhat,
tlrmchlsmth,
yewentao256 and
youkaichao
as code owners
August 6, 2026 11:45
hmellor
approved these changes
Aug 6, 2026
hmellor
enabled auto-merge (squash)
August 6, 2026 16:09
Contributor
|
Hi @music-dino, the pre-commit checks have failed. Please run: uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, |
Member
|
/ci run |
Member
|
/ci run |
|
✅ Triggered Buildkite CI #82815 for commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
After PR #49990, two gguf tests soft failed on the nightly https://buildkite.com/vllm/ci/builds/82629/list?sid=019fd5a9-db3f-42ba-9b21-993c983b2c7d&tab=output
with the following error:
Root cause
ModelConfig can load config and weights from different repos. The GGUF plugin redirects model to the base repo (Qwen/Qwen3-0.6B) for config while keeping the GGUF weights repo (unsloth/Qwen3-0.6B-GGUF) in model_weights.
Currently revision is resolved against self.model unconditionally
Because revision is a single field shared by all repos, this base-repo hash is then handed to snapshot_download for the weights repo. huggingface_hub sees an already-resolved revision, skips re-resolving, and requests the base repo's commit from the weights repo. Previously revision stayed None, so snapshot_download resolved main against the weights repo correctly.
This PR only resolves the shared revision against self.model when the weights actually come from the same repo.
Test Plan
Test Result
Previously both tests failed with the aforementioned error, now they pass