[Bugfix][Build] Patch stable string memleak fix from 2.14 for 2.13 - #51185
Merged
Merged
Conversation
Signed-off-by: Jane Xu <janeyx@meta.com>
janeyx99
marked this pull request as ready for review
August 7, 2026 15:42
janeyx99
requested review from
Harry-Chen,
LucasWilkinson and
tlrmchlsmth
as code owners
August 7, 2026 15:42
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
Harry-Chen
changed the title
Harry-Chen
changed the title
|
✅ @janeyx99, CI is now available for this PR.
|
Member
|
/ci run |
|
✅ Triggered Buildkite CI #82969 for commit |
Harry-Chen
approved these changes
Aug 9, 2026
Harry-Chen
enabled auto-merge (squash)
August 9, 2026 04:08
ywang96
disabled auto-merge
August 9, 2026 04:12
Member
|
cc @atalman: Should you do the torch 2.14 transition later, please include a revert of this PR in your changes. Thx! |
|
This PR fix #50150 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The stable ABI header had a memory leak for strings that was patched recently (pytorch/pytorch@7f0ec65) and will make it into our 2.14 release. This PR ports it over for the interim. This PR should be reverted once torch 2.14 is the build version for vllm. Note that this does not change versioning support for the stable ABI, we can still target 2.11 onwards.
Test Plan
CI
It did build locally and work for me, as well as for a downstream developer.
Test Result
green, hopefully
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.