[Misc] Simplify code and fix type annotations in conftest.py#5118
Merged
ywang96 merged 2 commits intovllm-project:mainfrom Jun 2, 2024
DarkLight1337:fix-conftest-types
Merged
[Misc] Simplify code and fix type annotations in conftest.py#5118ywang96 merged 2 commits intovllm-project:mainfrom DarkLight1337:fix-conftest-types
conftest.py#5118ywang96 merged 2 commits intovllm-project:mainfrom
DarkLight1337:fix-conftest-types
Conversation
This was referenced May 30, 2024
Member
Author
chengzhi-lu
pushed a commit
to chengzhi-lu/vllm-infersche
that referenced
this pull request
Jun 3, 2024
chengzhi-lu
pushed a commit
to chengzhi-lu/vllm-infersche
that referenced
this pull request
Jun 6, 2024
robertgshaw2-redhat
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
Jun 11, 2024
joerunde
pushed a commit
to joerunde/vllm
that referenced
this pull request
Jun 17, 2024
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jun 27, 2024
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jul 8, 2024
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jul 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As in title
@rkooo567 after this is merged, I'll edit #5017 to enable type checking under
tests/directory.