fix(security): restore incremental marker search cursors in thinking budget state - #51133
Open
jperezdealgaba wants to merge 1 commit into
Open
jperezdealgaba wants to merge 1 commit into
jperezdealgaba wants to merge 1 commit into
Conversation
…budget state The thinking_token_budget state machine re-scans the entire output history on every decode step when markers are absent, resulting in O(L^2) total work. An unauthenticated client can exploit this via valid API parameters to degrade latency for co-tenant requests. Restore independent per-marker search cursors that advance past already-searched tokens, bounding per-step work to O(delta) and total work to O(L). Signed-off-by: Jose Perez <jperezde@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: jperezde <jperezde@redhat.com>
jperezdealgaba
requested review from
22quinn,
houseroad and
njhill
as code owners
August 5, 2026 08:11
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
njhill
added
the
mrv1-only
This was referenced Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The thinking_token_budget state machine re-scans the entire output history on every decode step when markers are absent, resulting in O(L^2) total work. An unauthenticated client can exploit this via valid API parameters to degrade latency for co-tenant requests.
Restore independent per-marker search cursors that advance past already-searched tokens, bounding per-step work to O(delta) and total work to O(L).