Repository navigation
[Rust][Benchmark] Support HF ShareGPT datasets in multi-turn mode #51104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a user does a small HF multi-turn run first, such as
--num-prompts 1 --dry-run, this call asksdownload_hf_datasetto cache only that many rows; the helper's cache key is just dataset/config/split and it returns any existing file before checking the requested row count. A later benchmark of the same HF ShareGPT dataset with more conversations will therefore load the undersized cache andload_sharegpt_multi_turnwill oversample the few cached conversations, producing repeated conversations and misleading benchmark results. Please either make the HF cache size-aware or ensure this path fetches enough rows when the existing cache is too small.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this. This appears to be a pre-existing issue in the HF dataset cache rather than something introduced by this PR: the current single-turn HF path on
mainalready callsdownload_hf_dataset(..., config.num_prompts)and relies on the same dataset/config/split-only cache key before oversampling the loaded rows. This PR reuses that existing downloader contract for multi-turn loading without changing its cache behavior.I agree that making the cache size-aware would improve both single-turn and multi-turn HF benchmarks, but that requires changing the shared cache contract and deserves its own focused fix and regression coverage. I would prefer to keep this PR scoped to enabling ShareGPT-format HF datasets in the existing multi-turn pipeline so the behavior change remains small and reviewable.