Conversation
Signed-off-by: Markov Ilya <markovilya197@gmail.com>
|
Hi @ilmarkov — after coordinating with the maintainers we're consolidating the DSV4 DSpark fixes into a single PR, which I'm opening shortly and which will reference this one. Your work is included rather than replaced: the Two deliberate differences from this PR:
The consolidated PR carries four further fixes DSpark needs to run end-to-end, with gsm8k n=1319 evaluations across IFB and P/D. Happy to reshape this if you'd rather land yours first and have us stack on top — just say the word. |
|
This pull request has merge conflicts that must be resolved before it can be |
|
Close as resolved in #52809 |
DSpark non-causal draft batches allocate
decode_swa_indiceswithnoncausal_index_width(wider thanwindow_size). FlashInfer DSV4 sparseMLA still reshaped / passed
self.window_sizeintobuild_flashinfer_mixed_sparse_indices, which crashes those drafts, e.g.:decode_swa_widthtoDeepseekSparseSWAMetadataand set it in the SWAbuilder (
window_sizeornoncausal_index_width)._build_sparse_index_metadataand the ROCMragged conversion path.
Test Plan
pytest tests/kernels/attention/test_flashmla_sparse.pyattention_backend: FLASHINFER_MLA_SPARSE_DSV4Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.