[Misc] Avoid importing nixl_ep on every vllm serve config - #50879
Merged
vllm-bot merged 2 commits intoAug 4, 2026
Merged
Conversation
NickLucche
requested review from
mgoin,
pavanimajety and
zyongye
as code owners
August 3, 2026 14:22
tlrmchlsmth
approved these changes
Aug 3, 2026
yewentao256
approved these changes
Aug 3, 2026
yewentao256
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks for the work!
njhill
enabled auto-merge (squash)
August 3, 2026 21:32
This was referenced Aug 5, 2026
Contributor
|
@NickLucche FYI, this PR broke some CI tests on mi300, unexpectedly (and fixed by #51110): e.g. |
1 task
Contributor
|
Nothing is wrong per-se here: #51151 Surprising the CI did not catch this though, are there no ROCm + AITER tests running on PRs? |
Member
|
@fxmarty-amd CI caught the issue and the AMD test that was supposed to fail indeed failed. |
Member
|
@NickLucche we ll need to revert this PR. Cause it's breaking ROCm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Avoid importing nixl_ep all the time we boot up vllm. Instead, only do it lazily when needed (dpep configuration).
Right now if you do
vllm serve ...import_utils will try to resolve nixl_ep, and in this case even log "unrelated" import failuresas this configuration can then go on and run just fine, as no DPEP is needed (I have no libcudart 12 on this machine, but it only matters if it's actually needed).
cc @yewentao256 @DarkLight1337