[ROCm] Restore Inkling MTP backend parity - #50806
Merged
Merged
Conversation
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
Contributor
|
Thanks @AndreasKaratzas LGTM! |
AndreasKaratzas
marked this pull request as ready for review
August 3, 2026 15:32
AndreasKaratzas
requested review from
dllehr-amd,
hongxiayang and
tjtanaa
as code owners
August 3, 2026 15:32
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Member
|
Can you share some validation results? |
Member
Author
|
@tjtanaa Looks more or less the same to me.
Draft acceptance rate is effectively unchanged: both head runs are approximately +0.04 - 0.05 percentage points versus base. GSM8K also remains within normal run-to-run variation. |
tjtanaa
approved these changes
Aug 4, 2026
tjtanaa
enabled auto-merge (squash)
August 4, 2026 04:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #48892 added multi-layer MTP orchestration only to the NVIDIA copy and left the intentionally aligned AMD file stale. That omission causes the byte-alignment check to fail in the Inkling step. Inkling currently permits only one speculative token, so this restores the supported MTP=1 path without enabling unvalidated ROCm MTP>1 execution. The complete ROCm alignment test file passes locally.