Skip to content

[ROCm][CI] Fall back to lossless Kimi K3 MXFP4 emulation on gfx942 - #50516

Merged
mgoin merged 1 commit into
vllm-project:mainfrom
ROCm:akaratza_kimi_k3_mxfp4_emulation
Jul 31, 2026
Merged

[ROCm][CI] Fall back to lossless Kimi K3 MXFP4 emulation on gfx942#50516
mgoin merged 1 commit into
vllm-project:mainfrom
ROCm:akaratza_kimi_k3_mxfp4_emulation

Conversation

@AndreasKaratzas

Copy link
Copy Markdown
Member
  • git bisect identified aeeb36b1f171, vLLM #50000, as the first revision with both Kimi K3 failures.
  • Kimi K3's default MXFP4 RoutedExperts path only advertises AITER on ROCm, but the native backend rejects SiTU on MI300/gfx942 and leaves the model without a selectable backend.

Motivation:

PR #50000 defaults Kimi K3 to an MXFP4 RoutedExperts configuration. The model-specific native path handles gfx950, while gfx942 reaches the generic MXFP4 MoE oracle. That oracle offered only AITER_MXFP4_BF16 on ROCm. AITER rejects this SiTU/gfx942 combination, leaving no selectable backend and raising NotImplementedError during model construction. The tensor-schema test fails for the same reason before reaching schema processing. The emulation leaf also treated the generic configuration as W4A4. Kimi's checkpoint is weight-only W4A16, so the fallback must keep activations in BF16 and consume the checkpoint's packed MXFP4 layout without conversion.

Signed-off-by: Andreas Karatzas <Andreas.Karatzas@amd.com>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@AndreasKaratzas AndreasKaratzas added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 31, 2026
@mergify mergify Bot added quantization kimi k3 rocm Related to AMD ROCm labels Jul 31, 2026
@github-project-automation github-project-automation Bot moved this to Todo in AMD Jul 31, 2026
@mgoin
mgoin merged commit 5233368 into vllm-project:main Jul 31, 2026
130 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in AMD Jul 31, 2026
@AndreasKaratzas
AndreasKaratzas deleted the akaratza_kimi_k3_mxfp4_emulation branch July 31, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

k3 kimi quantization ready ONLY add when PR is ready to merge/full CI is needed rocm Related to AMD ROCm

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants