Skip to content

[MRV2] Always build attn metadata at capture time (#49364) - #49995

Merged
njhill merged 1 commit into
mainfrom
always-build-attn
Jul 27, 2026
Merged

[MRV2] Always build attn metadata at capture time (#49364)#49995
njhill merged 1 commit into
mainfrom
always-build-attn

Conversation

@njhill

@njhill njhill commented Jul 27, 2026

Copy link
Copy Markdown
Member

This reinstates @WoosukKwon's PR #49364, which was reverted since it exposed a MRV2 bug that broke some CI tests. That's now been fixed by #49751.

Signed-off-by: Woosuk Kwon <woosuk@inferact.ai>
(cherry picked from commit 6049424)

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@njhill njhill added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 27, 2026
@github-project-automation github-project-automation Bot moved this to Ready in NVIDIA Jul 27, 2026
@njhill
njhill enabled auto-merge (squash) July 27, 2026 16:06
@njhill
njhill merged commit 8112b6c into main Jul 27, 2026
110 of 112 checks passed
@njhill
njhill deleted the always-build-attn branch July 27, 2026 17:25
@github-project-automation github-project-automation Bot moved this from Ready to Done in NVIDIA Jul 27, 2026
edwinlim0919 pushed a commit to chaeminlim-mb/vllm that referenced this pull request Jul 29, 2026
vllm-project#49995)

Signed-off-by: Woosuk Kwon <woosuk@inferact.ai>
Co-authored-by: Woosuk Kwon <woosuk@inferact.ai>
aoshen02 pushed a commit to zllion/vllm that referenced this pull request Aug 1, 2026
vllm-project#49995)

Signed-off-by: Woosuk Kwon <woosuk@inferact.ai>
Co-authored-by: Woosuk Kwon <woosuk@inferact.ai>
Signed-off-by: aoshen02 <aoshen@inferact.ai>
pranavthakur0-0 pushed a commit to pranavthakur0-0/vllm that referenced this pull request Aug 4, 2026
vllm-project#49995)

Signed-off-by: Woosuk Kwon <woosuk@inferact.ai>
Co-authored-by: Woosuk Kwon <woosuk@inferact.ai>
itej89 pushed a commit to itej89/vllm that referenced this pull request Aug 4, 2026
vllm-project#49995)

Signed-off-by: Woosuk Kwon <woosuk@inferact.ai>
Co-authored-by: Woosuk Kwon <woosuk@inferact.ai>
Signed-off-by: Tej Kiran <kiran.tej@amd.com>
aditi-amd pushed a commit to aditi-amd/vllm that referenced this pull request Aug 4, 2026
vllm-project#49995)

Signed-off-by: Woosuk Kwon <woosuk@inferact.ai>
Co-authored-by: Woosuk Kwon <woosuk@inferact.ai>
Signed-off-by: root <root@smci355-ccs-aus-m02-09.cs-aus.dcgpu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

nvidia ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants