[ROCm] Fix and optimize GPT-J-style MRoPE - #49906
Merged
Merged
Conversation
Assisted-by: OpenAI Codex Signed-off-by: Andreas Karatzas <akaratza@amd.com>
Signed-off-by: Andreas Karatzas <akaratza@amd.com> Assisted-by: OpenAI Codex
AndreasKaratzas
changed the title
Use the vLLM platform abstraction when selecting the ROCm-specific one-wave launch shape. Assisted-by: OpenAI Codex Signed-off-by: Andreas Karatzas <akaratza@amd.com>
AndreasKaratzas
marked this pull request as ready for review
July 27, 2026 03:33
AndreasKaratzas
requested review from
WoosukKwon,
mgoin,
tlrmchlsmth,
yewentao256 and
zyongye
as code owners
July 27, 2026 03:33
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
AndreasKaratzas
added
the
ready
Member
|
This PR also changes the behaviour on NVIDIA, it is better to have someone that is able to validate the changes on NVIDIA to make sure there are no change in the performance. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://buildkite.com/vllm/amd-ci/builds/11254/list?sid=019f966b-1ec6-4bee-8ce6-acf444a98979&tab=output