[Model] Add VaultGemma via Transformers modeling backend - #49803
Merged
Conversation
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
|
Documentation preview: https://vllm--49803.org.readthedocs.build/en/49803/ |
mergify
Bot
added
documentation
Member
Author
|
cc @lucianommartins for Gemma |
Closed
1 task
DarkLight1337
approved these changes
Jul 25, 2026
hmellor
enabled auto-merge (squash)
July 25, 2026 11:06
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
github-project-automation
Bot
moved this from Todo
to Done
in Transformers modeling backend
iboiko-habana
pushed a commit
to vllm-project/vllm-gaudi
that referenced
this pull request
Jul 28, 2026
…e is_interleaved helper removed upstream (#1641) ## Root cause Upstream vLLM PR #49803 (commit 26d725c334) removed the `is_interleaved` helper from `vllm.transformers_utils.config`, inlining the check at its former call sites. The HPU model runner still imported that symbol at module load, so `EngineCore` / worker init crashed with `ImportError: cannot import name 'is_interleaved' from 'vllm.transformers_utils.config'` across run_unit_tests, data_parallel, pd_disaggregate and ~50 e2e load/generate jobs. ## Upstream PR vllm-project/vllm#49803 Removed `is_interleaved` from `vllm.transformers_utils.config` and inlined the layer-type check at its call sites. ## Fix Define a local `is_interleaved(config)` helper in `vllm_gaudi/v1/worker/hpu_model_runner.py` (identical behaviour to the removed upstream helper: True when the text config declares more than one distinct layer type) and drop the now-dead top-level import. ## Bug 2: set use_replayssm on HPUMambaMixer2 - **State machine id**: granite_4_h_hpumambamixer2_use_replayssm_missing - **Commit**: c219434891d11dfdeb4760c3ea0eda8b8364a21d - **vllm pin (this fix)**: 439f336212227833e126526d3c5f3ef3968dfbf5 - **Root cause**: Upstream vLLM PR #48018 (ReplaySSM) added `self.use_replayssm` / `self.replayssm_buffer_len` to `MambaMixer2.__init__`, read by the inherited `get_state_shape()` / `get_state_dtype()` during EngineCore init. `HPUMambaMixer2` overrides `__init__` and never set them, so Granite-4-H crashed with `AttributeError: 'HPUMambaMixer2' object has no attribute 'use_replayssm'`. - **Upstream**: vllm-project/vllm#48018 - **Fix**: Set `use_replayssm=False` and `replayssm_buffer_len=None` in the HPU `__init__` (HPU has no replay decode kernel; conv+SSM path is non-replay). - **Verification**: HPU re-verify of full stack PASS against vllm@439f336212227833e126526d3c5f3ef3968dfbf5 (granite-4.0-h-small e2e load/generate; both fixes exercised, EngineCore init clean, coherent generations). --------- Signed-off-by: Paweł Olejniczak <pawelx.olejniczak@intel.com>
libinta
pushed a commit
to libinta/vllm-gaudi
that referenced
this pull request
Jul 28, 2026
…e is_interleaved helper removed upstream (vllm-project#1641) ## Root cause Upstream vLLM PR #49803 (commit 26d725c334) removed the `is_interleaved` helper from `vllm.transformers_utils.config`, inlining the check at its former call sites. The HPU model runner still imported that symbol at module load, so `EngineCore` / worker init crashed with `ImportError: cannot import name 'is_interleaved' from 'vllm.transformers_utils.config'` across run_unit_tests, data_parallel, pd_disaggregate and ~50 e2e load/generate jobs. ## Upstream PR vllm-project/vllm#49803 Removed `is_interleaved` from `vllm.transformers_utils.config` and inlined the layer-type check at its call sites. ## Fix Define a local `is_interleaved(config)` helper in `vllm_gaudi/v1/worker/hpu_model_runner.py` (identical behaviour to the removed upstream helper: True when the text config declares more than one distinct layer type) and drop the now-dead top-level import. ## Bug 2: set use_replayssm on HPUMambaMixer2 - **State machine id**: granite_4_h_hpumambamixer2_use_replayssm_missing - **Commit**: c219434891d11dfdeb4760c3ea0eda8b8364a21d - **vllm pin (this fix)**: 439f336212227833e126526d3c5f3ef3968dfbf5 - **Root cause**: Upstream vLLM PR #48018 (ReplaySSM) added `self.use_replayssm` / `self.replayssm_buffer_len` to `MambaMixer2.__init__`, read by the inherited `get_state_shape()` / `get_state_dtype()` during EngineCore init. `HPUMambaMixer2` overrides `__init__` and never set them, so Granite-4-H crashed with `AttributeError: 'HPUMambaMixer2' object has no attribute 'use_replayssm'`. - **Upstream**: vllm-project/vllm#48018 - **Fix**: Set `use_replayssm=False` and `replayssm_buffer_len=None` in the HPU `__init__` (HPU has no replay decode kernel; conv+SSM path is non-replay). - **Verification**: HPU re-verify of full stack PASS against vllm@439f336212227833e126526d3c5f3ef3968dfbf5 (granite-4.0-h-small e2e load/generate; both fixes exercised, EngineCore init clean, coherent generations). --------- Signed-off-by: Paweł Olejniczak <pawelx.olejniczak@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EngineArgswhere full attention models were being treated as sliding if both of these conditions were true:layer_typeswith allfull_attention(thereforeis_interleaved=False)sliding_window: intpresent in the configVaultGemma(which exhibited this) to the model registry via the Transformers modeling backendCloses #49795