Repository navigation
Make bare hugging_face imports forbidden - #49726
Merged
Merged
Conversation
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
hmellor
requested review from
AndreasKaratzas,
DarkLight1337,
NickLucche,
WoosukKwon,
aarnphm,
bbrowning,
chaunceyjiang,
jeejeelee,
mgoin,
noooop,
pavanimajety,
robertgshaw2-redhat,
sfeng33,
tjtanaa,
tlrmchlsmth,
yewentao256,
ywang96 and
zyongye
as code owners
July 24, 2026 13:32
DarkLight1337
approved these changes
Jul 24, 2026
DarkLight1337
enabled auto-merge (squash)
July 24, 2026 13:50
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Member
|
I think all of the previously red test groups have been fixed, so I m rebasing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#43857 added library info most HF Hub requests but it didn't enforce that the situation didn't degrade.
This PR adds
huggingface_hubas a forbidden import so all requests will go throughhf_apiandhf_fs.