Skip to content

Make bare hugging_face imports forbidden - #49726

Merged
vllm-bot merged 3 commits into
vllm-project:mainfrom
hmellor:enforce-repo-utils
Jul 25, 2026
Merged

vllm-bot merged 3 commits into
vllm-project:mainfrom
hmellor:enforce-repo-utils

Conversation

@hmellor

@hmellor hmellor commented Jul 24, 2026

Copy link
Copy Markdown
Member

#43857 added library info most HF Hub requests but it didn't enforce that the situation didn't degrade.

This PR adds huggingface_hub as a forbidden import so all requests will go through hf_api and hf_fs.

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@mergify mergify Bot added multi-modality Related to multi-modality (#4194) mistral Related to Mistral models gpt-oss Related to GPT-OSS models tool-calling labels Jul 24, 2026
@github-project-automation github-project-automation Bot moved this from To Triage to Ready in gpt-oss Issues & Enhancements Jul 24, 2026
@DarkLight1337
DarkLight1337 enabled auto-merge (squash) July 24, 2026 13:50
@github-actions github-actions Bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 24, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>

@AndreasKaratzas AndreasKaratzas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndreasKaratzas

Copy link
Copy Markdown
Member

I think all of the previously red test groups have been fixed, so I m rebasing.

@vllm-bot
vllm-bot merged commit ca0defa into vllm-project:main Jul 25, 2026
118 of 120 checks passed
@hmellor
hmellor deleted the enforce-repo-utils branch July 25, 2026 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gpt-oss Related to GPT-OSS models mistral Related to Mistral models multi-modality Related to multi-modality (#4194) ready ONLY add when PR is ready to merge/full CI is needed tool-calling

Projects

Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants