Conversation
Signed-off-by: omerpaz95 <omerpaz95@gmail.com>
omerpaz95
requested review from
ApostaC,
WoosukKwon,
alexm-redhat,
heheda12345,
ivanium,
njhill,
orozery,
robertgshaw2-redhat and
ywang96
as code owners
July 23, 2026 11:15
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
NickLucche
approved these changes
Jul 27, 2026
Signed-off-by: Nicolò Lucchesi <nicolo.lucchesi@gmail.com>
NickLucche
enabled auto-merge (squash)
July 27, 2026 12:44
auto-merge was automatically disabled
July 28, 2026 08:35
Head branch was pushed to by a user without write access
Contributor
|
This pull request has merge conflicts that must be resolved before it can be |
Contributor
|
Hi @omerpaz95, the pre-commit checks have failed. Please run: uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, |
Collaborator
|
/ci run |
|
✅ Triggered Buildkite CI #82759 for commit |
Collaborator
|
@orozery @NickLucche CI is pass, maybe we can merge it? |
Collaborator
|
/ci run |
|
✅ Triggered Buildkite CI #83072 for commit |
Contributor
Author
|
Thanks @Isotr0py @gty111 @yewentao256 |
zyp2014
pushed a commit
to zyp2014/vllm
that referenced
this pull request
Aug 21, 2026
…duler (vllm-project#49579) Signed-off-by: omerpaz95 <omerpaz95@gmail.com> Signed-off-by: Nicolò Lucchesi <nicolo.lucchesi@gmail.com> Co-authored-by: Nicolò Lucchesi <nicolo.lucchesi@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The scheduler builds EC (Encoder Cache) connector metadata and calls update_state_after_alloc, request_finished, etc. on the EC Connector, but update_connector_output — the hook that lets an EC connector consume worker-side ECConnectorOutput — was never invoked from anywhere. This wires it into Scheduler.update_from_output, mirroring the existing KV connector call (self.connector.update_connector_output(kv_connector_output)).
This is currently a no-op for both shipped EC connectors (ECCPUConnector, ECExampleConnector), which don't override the base-class hook — this PR only completes the plumbing so a connector implementation can rely on it.
Test Plan
python pytest tests/v1/core/test_scheduler.py -k test_ec_connector_update_connector_output_calledAdded test_ec_connector_update_connector_output_called in tests/v1/core/test_scheduler.py, mirroring the existing KV connector coverage (test_scheduler_kv_connector_stats): mocks scheduler.ec_connector.update_connector_output, drives a ModelRunnerOutput carrying an ECConnectorOutput, and asserts the mock is called with it.