Skip to content

Update test_ignore_eos#4898

Merged
DarkLight1337 merged 4 commits intomainfrom
simon-mo/test-ignore-eos
Jun 2, 2024
Merged

Update test_ignore_eos#4898
DarkLight1337 merged 4 commits intomainfrom
simon-mo/test-ignore-eos

Conversation

@simon-mo
Copy link
Copy Markdown
Collaborator

This PR extend the test_ignore_eos with more prompts, precisions, and add llama2 models.

Comment thread tests/samplers/test_ignore_eos.py Outdated
@pytest.mark.parametrize("max_tokens", [1024])
def test_beam_search_single_input(
@pytest.mark.parametrize("max_tokens", [512])
def test_ignore_eos(
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this test name originally wrong?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) May 31, 2024 04:58
@DarkLight1337 DarkLight1337 disabled auto-merge May 31, 2024 05:15
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) May 31, 2024 05:15
@DarkLight1337 DarkLight1337 merged commit ed59a7e into main Jun 2, 2024
chengzhi-lu pushed a commit to chengzhi-lu/vllm-infersche that referenced this pull request Jun 3, 2024
robertgshaw2-redhat pushed a commit to neuralmagic/nm-vllm that referenced this pull request Jun 11, 2024
joerunde pushed a commit to joerunde/vllm that referenced this pull request Jun 17, 2024
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jun 27, 2024
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jul 8, 2024
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jul 24, 2024
@simon-mo simon-mo deleted the simon-mo/test-ignore-eos branch October 28, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants