[Do not merge!] [Build] Migrate vendored DeepGEMM from pybind to TORCH_LIBRARY (abi3) #48962
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,85 +1,52 @@ | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # SPDX-FileCopyrightText: Copyright contributors to the vLLM project | ||
| """Build DeepGEMM's TORCH_LIBRARY extension and copy vendored artifacts. | ||
|
|
||
| DeepGEMM now registers ops via TORCH_LIBRARY into ``deep_gemm._C_extension`` | ||
| (abi3) and exposes the legacy API through ``deep_gemm/_C.py``. This driver | ||
| delegates to DeepGEMM's ``setup.py build_ext --inplace`` and copies the shim | ||
| plus extension into the cmake output directory. | ||
|
|
||
| Usage: python build_deepgemm_C.py <DEEPGEMM_SRC_DIR> <OUTPUT_DIR> | ||
| """ | ||
|
|
||
| import os | ||
| import shutil | ||
| import subprocess | ||
| import sys | ||
| from pathlib import Path | ||
|
|
||
| if len(sys.argv) != 3: | ||
| sys.exit(f"usage: {sys.argv[0]} <SRC> <OUT>") | ||
|
|
||
| src = Path(sys.argv[1]).resolve() | ||
| out = Path(sys.argv[2]).resolve() | ||
| _pkg = src / "deep_gemm" | ||
| out.mkdir(parents=True, exist_ok=True) | ||
|
|
||
| if not (_pkg / "_C.py").is_file(): | ||
| sys.exit( | ||
| f"DeepGEMM source at {src} is missing deep_gemm/_C.py; " | ||
| "expected TORCH_LIBRARY migration layout" | ||
| ) | ||
|
|
||
| # Avoid DeepGEMM's clean-git assertion when vendoring a local dirty tree. | ||
| env = os.environ.copy() | ||
| env.pop("DG_SKIP_CUDA_BUILD", None) | ||
|
|
||
| print(f"[build_deepgemm_C] building in {src} with {sys.executable}", flush=True) | ||
| subprocess.check_call( | ||
|
Contributor
Author
There was a problem hiding this comment. Use deep_gemm's setup.py to build deep_gemm
Contributor
Author
There was a problem hiding this comment. This call also gets Python_EXECUTABLE so building DeepGEMM's abi3 extension always tracks whatever Python vLLM is currently being built for. |
||
| [sys.executable, "setup.py", "build_ext", "--inplace"], | ||
| cwd=src, | ||
| env=env, | ||
| ) | ||
|
|
||
| shim = _pkg / "_C.py" | ||
| shutil.copy2(shim, out / shim.name) | ||
|
|
||
| so_files = sorted(_pkg.glob("_C_extension*.so")) | ||
| if not so_files: | ||
| sys.exit(f"DeepGEMM build did not produce deep_gemm/_C_extension*.so under {src}") | ||
| for so in so_files: | ||
| shutil.copy2(so, out / so.name) | ||
| print(f"[build_deepgemm_C] installed {so.name} -> {out}", flush=True) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,41 +1,45 @@ | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # SPDX-FileCopyrightText: Copyright contributors to the vLLM project | ||
|
|
||
| """Assert the vendored DeepGEMM package has the TORCH_LIBRARY binding layout. | ||
|
|
||
| Expects ``deep_gemm/_C.py`` plus a single ``_C_extension*.so`` (abi3) under | ||
| ``vllm.third_party.deep_gemm``. Run after vLLM is installed, e.g. the H100 | ||
| deepgemm kernel tests in .buildkite/test_areas/kernels.yaml. | ||
| """ | ||
|
|
||
| import importlib.util | ||
| import sys | ||
| from pathlib import Path | ||
|
|
||
|
|
||
|
Contributor
Author
There was a problem hiding this comment. This file used to check each required python version in |
||
| def main() -> int: | ||
| spec = importlib.util.find_spec("vllm.third_party.deep_gemm") | ||
| if spec is None or spec.origin is None: | ||
| print( | ||
| "vllm.third_party.deep_gemm not importable; is vllm installed?", | ||
| file=sys.stderr, | ||
| ) | ||
| return 1 | ||
| pkg_dir = Path(spec.origin).parent | ||
|
|
||
| shim = pkg_dir / "_C.py" | ||
| so_files = sorted(pkg_dir.glob("_C_extension*.so")) | ||
| missing = [] | ||
| if not shim.is_file(): | ||
| missing.append("_C.py") | ||
| if not so_files: | ||
| missing.append("_C_extension*.so") | ||
|
|
||
| print( | ||
| f"deepgemm vendored binding: shim={shim.is_file()}, " | ||
| f"extensions={[p.name for p in so_files]}" | ||
| ) | ||
| if missing: | ||
|
Contributor
Author
There was a problem hiding this comment. Now, it checks |
||
| print(f"missing: {missing}", file=sys.stderr) | ||
| return 1 | ||
| return 0 | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| raise SystemExit(main()) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This used to link private CPython symbols, so each python needed it's own C.cpython-3XY-….so.
Now, it builds against the CPython Limited/Stable ABI (Py_LIMITED_API), so one _C_extension.abi3.so works across supported CPythons.