[Model] Add Hopper FA4 relative attention for Inkling - #48858
Merged
Conversation
Route Hopper relative bias through standard FA4 score-mod while retaining tml-fa4 sheared bias on Blackwell. Co-authored-by: OpenAI Codex <codex@openai.com> Signed-off-by: Woosuk Kwon <woosuk@inferact.ai>
WoosukKwon
marked this pull request as ready for review
July 16, 2026 17:11
WoosukKwon
requested review from
AndreasKaratzas,
DarkLight1337 and
ywang96
as code owners
July 16, 2026 17:11
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Contributor
|
Hi @WoosukKwon, the pre-commit checks have failed. Please run: uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, |
This was referenced Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Inkling's current relative-attention path uses the tml-fa4 sheared-bias interface, which is a Blackwell-specific path. On Hopper, that reaches incompatible SM90 call signatures and split-KV constraints.
This change:
score_modplusaux_tensorsfor Inkling relative bias on Hopper (SM90);num_splits=1on Hopper;This is Python-only: no CMake, C++, CUDA, or tml-fa4 source changes.
Duplicate-work check
This does not duplicate an existing open PR. Before opening it, I ran:
All three searches returned no results.
Testing
The full test file ran on a GB200. It covers routing for SM90/SM100/SM110/SM120, the existing Blackwell sheared-bias matrix, and a forced numerical test of the regular FA4 score-mod path against the PyTorch reference. Hopper hardware was not available locally, so CI on H200 should validate actual SM90 compilation and execution.
Model evaluation
Served
thinkingmachines/Inkling-NVFP4with Model Runner V2, TP4, no MTP, andmax_model_len=8192:Ran vLLM's canonical GSM8K evaluator over the chat-completions API:
Full GSM8K result:
AI assistance
AI assistance was used to implement and test this change. The human submitter must review every changed line and understands and can defend the change end-to-end before marking this PR ready for review.