[Bugfix] Fix local speculators with dots in the name from classifying as custom_class - #48754
Merged
simon-mo merged 1 commit intoJul 16, 2026
Merged
Conversation
… as custom_class Signed-off-by: mgoin <mgoin64@gmail.com>
mgoin
requested review from
houseroad,
robertgshaw2-redhat,
tlrmchlsmth,
yewentao256 and
youkaichao
as code owners
July 15, 2026 16:35
Contributor
|
Hi @mgoin, the pre-commit checks have failed. Please run: uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, |
yewentao256
approved these changes
Jul 15, 2026
yewentao256
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks for the work!
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix speculative config so draft model names with dots (e.g. local
GLM-5.2-speculator.dsparkfolder) are not misclassified ascustom_classimport paths.Test Plan
Test Result
Before:
After: loads normally, same as using
RedHatAI/GLM-5.2-speculator.dsparkfor the modelEssential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.