[Bugfix][XPU] Fix Mamba state pointer overflow - #48109
Conversation
|
I had Before After: |
|
And now there is a conflict with freshly merged #48110 😐 |
|
@Oxygen56 |
af11afb to
89b52dd
Compare
|
Rebased onto the latest |
|
/ci run |
|
✅ Triggered Buildkite CI #82608 for commit |
|
/ci retry |
|
✅ Queued 1 failed job(s) for retry in Buildkite CI #82608. |
|
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Oxygen56 <jiangth99@163.com>
Signed-off-by: Oxygen56 <jiangth99@163.com>
5133492 to
8d88c60
Compare
|
/ci run |
|
❌ @mayuyuace, Only reviewers with write access can use CI commands before CI is delegated to the PR author. |
|
/ci run |
|
❌ @mayuyuace, Only reviewers with write access can use CI commands before CI is delegated to the PR author. |
|
/ci run |
|
✅ Triggered Buildkite CI #84369 for commit |
Signed-off-by: Oxygen56 <jiangth99@163.com> Signed-off-by: Wenhua Cheng <wenhua.cheng@intel.com>
Signed-off-by: Oxygen56 <jiangth99@163.com>
Signed-off-by: Oxygen56 <jiangth99@163.com> Signed-off-by: Wyett <wyettzeng@gmail.com>
Signed-off-by: Oxygen56 <jiangth99@163.com> Signed-off-by: Zhu, Zufang <zufang.zhu@intel.com>
Signed-off-by: Oxygen56 <jiangth99@163.com> Signed-off-by: khushali9 <khushali.desai9@gmail.com>
Signed-off-by: Oxygen56 <jiangth99@163.com>
Fixes #48059
Purpose
XPU USM device pointers can exceed the positive signed int64 range. The Mamba
align-mode fused copy path stores state tensor and block-table
data_ptr()values in
torch.int64metadata buffers before passing them to Triton kernels,so assigning a high-bit XPU pointer directly can raise:
This preserves the 64-bit pointer pattern by reinterpreting unsigned pointer
values as signed int64 before storing them in the existing metadata buffers. The
Triton kernel ABI stays unchanged.
Duplicate-work check: no open PR currently references #48059 or matches the
state_base_addrs/ overflow keywords.Test Plan
pre-commit run ruff-format --files vllm/v1/worker/mamba_utils.py tests/v1/worker/test_mamba_utils.pypre-commit run ruff-check --files vllm/v1/worker/mamba_utils.py tests/v1/worker/test_mamba_utils.pypython -m pytest tests/v1/worker/test_mamba_utils.py -qTest Result
ruff-formatpassedruff-checkpassedtests/v1/worker/test_mamba_utils.py: 3 passed, 17 skippedI could not run the full XPU serving repro locally because this environment does
not have the reported Intel Arc/XPU setup and hybrid checkpoint.
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.