Skip to content

Allow configuring DP update interval with an env var #48027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
omera-nv wants to merge 1 commit into from
Closed

Allow configuring DP update interval with an env var #48027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions vllm/envs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,7 @@
VLLM_DP_MASTER_IP: str = ""
VLLM_DP_MASTER_PORT: int = 0
VLLM_RANDOMIZE_DP_DUMMY_INPUTS: bool = False
VLLM_DP_COORDINATOR_UPDATE_INTERVAL_MS: int = 100
VLLM_RAY_DP_PACK_STRATEGY: Literal["strict", "fill", "span"] = "strict"
VLLM_RAY_DP_PLACEMENT_NODE_IPS: str = ""
VLLM_RAY_EXTRA_ENV_VAR_PREFIXES_TO_COPY: str = ""
Expand Down Expand Up @@ -1374,6 +1375,10 @@ def _resolve_rust_frontend_path() -> str | None:
"VLLM_RANDOMIZE_DP_DUMMY_INPUTS": lambda: (
os.environ.get("VLLM_RANDOMIZE_DP_DUMMY_INPUTS", "0") == "1"
),
# Minimum interval for the DP coordinator's periodic state updates
"VLLM_DP_COORDINATOR_UPDATE_INTERVAL_MS": lambda: int(
os.getenv("VLLM_DP_COORDINATOR_UPDATE_INTERVAL_MS", "100")
),
# Strategy to pack the data parallel ranks for Ray.
# Available options:
# - "fill":
Expand Down
9 changes: 6 additions & 3 deletions vllm/v1/engine/coordinator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import msgspec.msgpack
import zmq

import vllm.envs as envs
from vllm.config import ParallelConfig
from vllm.logger import init_logger
from vllm.utils.network_utils import make_zmq_socket
Expand Down Expand Up @@ -146,15 +147,17 @@ class DPCoordinatorProc:
def __init__(
self,
engine_count: int,
min_stats_update_interval_ms: int = 100,
min_stats_update_interval_ms: int | None = None,
enable_wave_coordination: bool = True,
):
set_process_title("DPCoordinator")
self.ctx = zmq.Context()

self.engines = [EngineState() for _ in range(engine_count)]

self.stats_update_interval_ms = min_stats_update_interval_ms
self.stats_update_interval_ms = (
min_stats_update_interval_ms or envs.VLLM_DP_COORDINATOR_UPDATE_INTERVAL_MS
)
self.enable_wave_coordination = enable_wave_coordination

@staticmethod
Expand All @@ -164,7 +167,7 @@ def run_coordinator(
back_output_address: str,
back_publish_address: str,
zmq_addr_pipe=None,
min_stats_update_interval_ms: int = 100,
min_stats_update_interval_ms: int | None = None,
enable_wave_coordination: bool = True,
):
coordinator = DPCoordinatorProc(
Expand Down
Loading