[Bugfix] Fix call to init_logger in openai server#4765
Merged
DarkLight1337 merged 2 commits intovllm-project:mainfrom Jun 1, 2024
Merged
[Bugfix] Fix call to init_logger in openai server#4765DarkLight1337 merged 2 commits intovllm-project:mainfrom
DarkLight1337 merged 2 commits intovllm-project:mainfrom
Conversation
Member
|
Sorry for keeping you waiting for so long.
Edit: Ok it seems that my understanding was wrong. In that case, let's adopt the first solution, since your second solution opens up the possibility of forgetting to pass in |
DarkLight1337
approved these changes
May 31, 2024
chengzhi-lu
pushed a commit
to chengzhi-lu/vllm-infersche
that referenced
this pull request
Jun 3, 2024
robertgshaw2-redhat
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
Jun 11, 2024
joerunde
pushed a commit
to joerunde/vllm
that referenced
this pull request
Jun 17, 2024
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jun 27, 2024
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jul 8, 2024
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jul 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when running the OpenAI entrypoint, all logs coming from this file will not be shown.
This is because the call to
init_loggerat the top of the file uses the__name__global variable, and it's value is__main__since this is the main file, which causes theinit_loggerfunction to return a logger with default configuration instead of the one configured in the logger file.To solve this I changed the call to
init_loggerto pass a string instead of__name__, but another possible and potentially more elegant solution would be changing theinit_loggerfunction so the logger name is optional, and omitting it in the OpenAI entrypoint: