[Spec Decode][Perf] Optimize padded EAGLE input prep and EAGLE3 layer0 RMSNorm concat - #47391
Closed
tanpinsiang wants to merge 2 commits into
Closed
[Spec Decode][Perf] Optimize padded EAGLE input prep and EAGLE3 layer0 RMSNorm concat#47391tanpinsiang wants to merge 2 commits into
tanpinsiang wants to merge 2 commits into
Conversation
Signed-off-by: Tan Pin Siang <tanpinsiang@gmail.com> Co-authored-by: vllmellm <vllm.ellm@embeddedllm.com> Co-authored-by: Hongxia Yang <hongxia.yang@amd.com> Co-authored-by: Jun Kang Chow <junkangchow@gmail.com>
Signed-off-by: Tan Pin Siang <tanpinsiang@gmail.com> Co-authored-by: vllmellm <vllm.ellm@embeddedllm.com> Co-authored-by: Hongxia Yang <hongxia.yang@amd.com> Co-authored-by: Jun Kang Chow <junkangchow@gmail.com>
tanpinsiang
force-pushed
the
eagle3-input-prep-rmsnorm
branch
from
July 2, 2026 14:57
998902f to
627f699
Compare
Contributor
Author
|
superseded by #47854 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the V1 EAGLE/EAGLE3 speculative decode path.
It replaces a small padded EAGLE input-prep Triton helper with torch tensor ops, and adds a guarded fused EAGLE3 layer-0 helper for:
cat([input_layernorm(embeds), hidden_norm(hidden_states)], dim=-1)What changed:
SpecDecodeBaseProposer.llama_eagle3layer-0 inputs.How to enable:
Scope and limitations:
llama_eagle3layer-0 draft model path.Verification
FP4 EAGLE3 MTP
Benchmark random input 8192 / output 1024 / random-range-ratio 0.8 / concurrent 64 / prompts 640, TP4.
Model:
amd/MiniMax-M3-MXFP4Draft model:
Inferact/MiniMax-M3-EAGLE3Note: These benchmark numbers were collected before recipes#621 clarified the nested
text_configoverride. The command below is updated to the working form; the A/B delta remains comparable because both arms used the same config, but absolute tok/s should be rerun with nested index-topk reuse.Baseline checkout
Run from the baseline checkout. For the isolated EAGLE3 layer0 fusion comparison, this was the parent of the fusion commit, i.e. padded EAGLE input prep included but RMSNorm concat fusion removed.
This PR: Run the same command from this PR checkout.
same environment and vllm serve command as baseline
Common benchmark command:
GSM8K
Result:
0.945 +/- 0.01620.945 +/- 0.0162