[Rust Frontend] Recover buffered text from incomplete tool calls at EOS - #47289
Merged
Conversation
Signed-off-by: reidliu41 <reid201711@gmail.com>
Member
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
BugenZhao
enabled auto-merge (squash)
July 3, 2026 03:19
jakki-amd
pushed a commit
to jakki-amd/vllm
that referenced
this pull request
Jul 6, 2026
…OS (vllm-project#47289) Signed-off-by: reidliu41 <reid201711@gmail.com>
lkk12014402
pushed a commit
to lkk12014402/vllm
that referenced
this pull request
Jul 8, 2026
…OS (vllm-project#47289) Signed-off-by: reidliu41 <reid201711@gmail.com>
mayuyuace
pushed a commit
to mayuyuace/vllm
that referenced
this pull request
Jul 9, 2026
…OS (vllm-project#47289) Signed-off-by: reidliu41 <reid201711@gmail.com> Signed-off-by: mayuyuace <qiming1.zhang@intel.com>
NickLucche
pushed a commit
to NickLucche/vllm
that referenced
this pull request
Jul 15, 2026
…OS (vllm-project#47289) Signed-off-by: reidliu41 <reid201711@gmail.com>
philippesic
pushed a commit
to philippesic/vllm-semantic-cache
that referenced
this pull request
Jul 19, 2026
…OS (vllm-project#47289) Signed-off-by: reidliu41 <reid201711@gmail.com>
plasticchris
pushed a commit
to plasticchris/vllm
that referenced
this pull request
Jul 20, 2026
…OS (vllm-project#47289) Signed-off-by: reidliu41 <reid201711@gmail.com>
aditi-amd
pushed a commit
to aditi-amd/vllm
that referenced
this pull request
Aug 4, 2026
…OS (vllm-project#47289) Signed-off-by: reidliu41 <reid201711@gmail.com> Signed-off-by: root <root@smci355-ccs-aus-m02-09.cs-aus.dcgpu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
When a Gemma4 tool-call stream is truncated before the closing marker,
Gemma4UnifiedParser::finish()returns an incomplete-tool-call error while the raw tool-call text remains buffered inside the parser. The unified stream wrapper previously closed parser state without recovering that buffer, so clients could receive onlyDoneand an empty assistant message.This PR mirrors the existing mid-stream parse-error fallback for end-of-stream finish errors: reset the parser, emit the recovered buffered text as a plain text delta, and close any open tool-call state. It also adds coverage for both the generic finish-error path and a real Gemma4 truncated tool-call stream.
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.