Skip to content

Forward fix nightly errors from #44589 - #47151

Merged
hmellor merged 4 commits into
vllm-project:mainfrom
hmellor:fix-load-weights
Jun 30, 2026
Merged

Forward fix nightly errors from #44589#47151
hmellor merged 4 commits into
vllm-project:mainfrom
hmellor:fix-load-weights

Conversation

@hmellor

@hmellor hmellor commented Jun 30, 2026

Copy link
Copy Markdown
Member

This PR forward fixes the failures introduced to main by #44589. Supersedes #47096.

Fixes for Language Models Test (MTEB):

  • Move the hf_to_vllm_mapper so it belongs to Gemma3Model so that it can load itself. This is necessary because Gemma3Model is registered directly as Gemma3TextModel
  • Reinstate the prefixing of model. to JinaEmbeddingsV5Model weights so that it can load correctly

Fix for Multi-Modal Models (Extended Generation 2):

  • Merge hf_to_vllm_mapper definitions. hf_to_vllm_mapper was defined twice in CohereForCausalLM, meaning that the one containing orig_to_new_stacked was overwritten

hmellor added 3 commits June 30, 2026 11:45
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@hmellor hmellor added ready ONLY add when PR is ready to merge/full CI is needed and removed aardvark labels Jun 30, 2026

@njhill njhill left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hmellor

@hmellor
hmellor enabled auto-merge (squash) June 30, 2026 12:17
@hmellor

hmellor commented Jun 30, 2026

Copy link
Copy Markdown
Member Author

I've started the two jobs that failed on nightly so we'll see confirmation that they are now fixed

@hmellor
hmellor merged commit 62c7d80 into vllm-project:main Jun 30, 2026
85 checks passed
@hmellor
hmellor deleted the fix-load-weights branch June 30, 2026 14:02
rjrock pushed a commit to rjrock/vllm that referenced this pull request Jul 1, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
lkk12014402 pushed a commit to lkk12014402/vllm that referenced this pull request Jul 8, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
noooop pushed a commit to noooop/vllm that referenced this pull request Jul 9, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Dao007forever pushed a commit to Dao007forever/vllm that referenced this pull request Jul 18, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
philippesic pushed a commit to philippesic/vllm-semantic-cache that referenced this pull request Jul 19, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
plasticchris pushed a commit to plasticchris/vllm that referenced this pull request Jul 20, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
aditi-amd pushed a commit to aditi-amd/vllm that referenced this pull request Aug 4, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: root <root@smci355-ccs-aus-m02-09.cs-aus.dcgpu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants