[KV-Offloading] Fix tensors_per_block stride - #46888
Merged
Merged
Conversation
varun-sundar-rabindranath
requested review from
ApostaC,
NickLucche,
orozery and
xuechendi
as code owners
June 27, 2026 03:02
Contributor
Author
tlrmchlsmth
approved these changes
Jun 27, 2026
tlrmchlsmth
left a comment
Member
There was a problem hiding this comment.
looks good to me, thank you for finding this.
I am following up with a integration tests that would have caught this.
Signed-off-by: Varun Sundar Rabindranath <varun-sundar-rabindranath@h100-01.nemg-001.lab.rdu2.dc.redhat.com> Signed-off-by: <>
auto-merge was automatically disabled
June 27, 2026 13:56
Head branch was pushed to by a user without write access
Member
|
adding integration tests here #46893 |
khluu
pushed a commit
that referenced
this pull request
Jun 28, 2026
Signed-off-by: <> Co-authored-by: Varun Sundar Rabindranath <varun-sundar-rabindranath@h100-01.nemg-001.lab.rdu2.dc.redhat.com> (cherry picked from commit 798185d)
wincent8
pushed a commit
to wincent8/vllm
that referenced
this pull request
Jun 29, 2026
Signed-off-by: <> Co-authored-by: Varun Sundar Rabindranath <varun-sundar-rabindranath@h100-01.nemg-001.lab.rdu2.dc.redhat.com>
rjrock
pushed a commit
to rjrock/vllm
that referenced
this pull request
Jul 1, 2026
Signed-off-by: <> Co-authored-by: Varun Sundar Rabindranath <varun-sundar-rabindranath@h100-01.nemg-001.lab.rdu2.dc.redhat.com>
noooop
pushed a commit
to noooop/vllm
that referenced
this pull request
Jul 9, 2026
Signed-off-by: <> Co-authored-by: Varun Sundar Rabindranath <varun-sundar-rabindranath@h100-01.nemg-001.lab.rdu2.dc.redhat.com> Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Dao007forever
pushed a commit
to Dao007forever/vllm
that referenced
this pull request
Jul 18, 2026
Signed-off-by: <> Co-authored-by: Varun Sundar Rabindranath <varun-sundar-rabindranath@h100-01.nemg-001.lab.rdu2.dc.redhat.com>
philippesic
pushed a commit
to philippesic/vllm-semantic-cache
that referenced
this pull request
Jul 19, 2026
Signed-off-by: <> Co-authored-by: Varun Sundar Rabindranath <varun-sundar-rabindranath@h100-01.nemg-001.lab.rdu2.dc.redhat.com>
plasticchris
pushed a commit
to plasticchris/vllm
that referenced
this pull request
Jul 20, 2026
Signed-off-by: <> Co-authored-by: Varun Sundar Rabindranath <varun-sundar-rabindranath@h100-01.nemg-001.lab.rdu2.dc.redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
On
mainOffloading connector fails forQwen/Qwen3.6-35B-A3B&nvidia/NVIDIA-Nemotron-3-Super-120B-A12B-FP8with the assertWhy:
PR #44577 introduced cross-layer layouts for DSV4. The PR introduced a change in the offloading/worker.py::register_kv_caches to set the 2D
tensors_per_blockstride directly from the layer_kv_cache. This is incorrect when the KV cache tensor is not layer packed.Fix:
Special case based on if the kv cache tensor is packed.
Test Plan
vllm-serve command:
lm_eval command:
Test Result
PR
nvidia/NVIDIA-Nemotron-3-Super-120B-A12B-FP8nvidia/NVIDIA-Nemotron-3-Super-120B-A12B-FP8 - without offloadingQwen/Qwen3.6-35B-A3BQwen/Qwen3.6-35B-A3B - without offloading